From owner-cvs-all  Sat Nov 18 20:27:13 2000
Delivered-To: cvs-all@freebsd.org
Received: from bsdhome.dyndns.org (unknown [24.25.2.13])
	by hub.freebsd.org (Postfix) with ESMTP
	id 67F9E37B479; Sat, 18 Nov 2000 20:27:08 -0800 (PST)
Received: from vger.bsdhome.com (vger [192.168.220.2])
	by bsdhome.dyndns.org (8.11.1/8.11.1) with ESMTP id eAJ4R2S11742;
	Sat, 18 Nov 2000 23:27:02 -0500 (EST)
	(envelope-from bsd@bsdhome.com)
Received: (from bsd@localhost)
	by vger.bsdhome.com (8.11.1/8.11.1) id eAJ4R1102496;
	Sat, 18 Nov 2000 23:27:01 -0500 (EST)
	(envelope-from bsd)
Date: Sat, 18 Nov 2000 23:27:01 -0500
From: Brian Dean <bsd@bsdhome.com>
To: "John W. De Boskey" <jwd@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/split split.c
Message-ID: <20001118232701.A2307@vger.bsdhome.com>
References: <200011190144.RAA60865@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200011190144.RAA60865@freefall.freebsd.org>; from jwd@FreeBSD.org on Sat, Nov 18, 2000 at 05:44:21PM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, Nov 18, 2000 at 05:44:21PM -0800, John W. De Boskey wrote:
> jwd         2000/11/18 17:44:21 PST
> 
>   Modified files:
>     usr.bin/split        split.c 
>   Log:
>   Add/fix the ability to split a file larger than 2 gigabytes.

You used size_t for the size, which is a 4 byte unsigned, yet you use
strtoq() to get the value, which is an 8 byte value.  Did you mean to
use off_t or, or did you mean to use strtoul()?

-Brian


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message