From owner-p4-projects@FreeBSD.ORG Tue Dec 5 18:53:41 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A721616A417; Tue, 5 Dec 2006 18:53:41 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6037216A407 for ; Tue, 5 Dec 2006 18:53:41 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9070043CA5 for ; Tue, 5 Dec 2006 18:53:00 +0000 (GMT) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB5IreNi047772 for ; Tue, 5 Dec 2006 18:53:40 GMT (envelope-from rdivacky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB5Ireqe047766 for perforce@freebsd.org; Tue, 5 Dec 2006 18:53:40 GMT (envelope-from rdivacky@FreeBSD.org) Date: Tue, 5 Dec 2006 18:53:40 GMT Message-Id: <200612051853.kB5Ireqe047766@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to rdivacky@FreeBSD.org using -f From: Roman Divacky To: Perforce Change Reviews Cc: Subject: PERFORCE change 111155 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2006 18:53:41 -0000 http://perforce.freebsd.org/chv.cgi?CH=111155 Change 111155 by rdivacky@rdivacky_witten on 2006/12/05 18:53:31 Lint wants /* FALLTHRU */ or /* FALLTHROUGH */ not /* fall through */ I noticed using the latter in the code... maybe we should change the lint? Affected files ... .. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#43 edit Differences ... ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#43 (text+ko) ==== @@ -909,7 +909,7 @@ case 0: args->mode |= S_IFREG; - /* fall through */ + /* FALLTHROUGH */ case S_IFREG: error = kern_open(td, path, UIO_SYSSPACE, O_WRONLY | O_CREAT | O_TRUNC, args->mode);