From owner-freebsd-usb@FreeBSD.ORG Fri Jul 28 17:36:13 2006 Return-Path: X-Original-To: freebsd-usb@FreeBSD.org Delivered-To: freebsd-usb@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD7D316A4E2; Fri, 28 Jul 2006 17:36:13 +0000 (UTC) (envelope-from qemu-l@saturn.kn-bremen.de) Received: from gwyn.kn-bremen.de (gwyn.kn-bremen.de [212.63.36.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5FA543D60; Fri, 28 Jul 2006 17:36:08 +0000 (GMT) (envelope-from qemu-l@saturn.kn-bremen.de) Received: from gwyn.kn-bremen.de (gwyn [127.0.0.1]) by gwyn.kn-bremen.de (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k6SHa6VP002093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 28 Jul 2006 19:36:06 +0200 Received: from saturn.kn-bremen.de (uucp@localhost) by gwyn.kn-bremen.de (8.13.4/8.13.4/Submit) with UUCP id k6SHa6QC002091; Fri, 28 Jul 2006 19:36:06 +0200 Received: from saturn.kn-bremen.de (nox@localhost [127.0.0.1]) by saturn.kn-bremen.de (8.13.6/8.13.6) with ESMTP id k6SHXqul007270; Fri, 28 Jul 2006 19:33:52 +0200 (CEST) (envelope-from nox@saturn.kn-bremen.de) Received: (from nox@localhost) by saturn.kn-bremen.de (8.13.6/8.13.6/Submit) id k6SHXp3F007269; Fri, 28 Jul 2006 19:33:51 +0200 (CEST) (envelope-from nox) From: Juergen Lock Date: Fri, 28 Jul 2006 19:33:51 +0200 To: Jung-uk Kim Message-ID: <20060728173351.GA6314@saturn.kn-bremen.de> Mail-Followup-To: Jung-uk Kim , freebsd-emulation@FreeBSD.org, freebsd-usb@FreeBSD.org, qemu-devel@nongnu.org References: <20060723224041.GA20196@saturn.kn-bremen.de> <20060725174719.GA16116@saturn.kn-bremen.de> <200607251906.10687.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607251906.10687.jkim@FreeBSD.org> User-Agent: Mutt/1.5.11 Cc: freebsd-emulation@FreeBSD.org, qemu-devel@nongnu.org, freebsd-usb@FreeBSD.org Subject: Re: FreeBSD qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED) X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2006 17:36:14 -0000 On Tue, Jul 25, 2006 at 07:06:02PM -0400, Jung-uk Kim wrote: > On Tuesday 25 July 2006 01:47 pm, Juergen Lock wrote: > > @@ -47,21 +43,20 @@ > > void set_float_rounding_mode(int val STATUS_PARAM) > > { > > STATUS(float_rounding_mode) = val; > > --#if defined(_BSD) && !defined(__APPLE__) > > -+#if defined(_BSD) && !defined(__APPLE__) && \ > > -+ (defined(__FreeBSD__) && __FreeBSD_version < 500000) > > +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10) > > ++#if (defined(_BSD) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10) > > fpsetround(val); > > #elif defined(__arm__) > > /* nothing to do */ > > FYI, a parenthesis is misplaced (Note: I just rearranged > the order to be more clearer): > > +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10) > ++#if (defined(_BSD) && !defined(__APPLE__) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) || \ > ++ (defined(HOST_SOLARIS) && HOST_SOLARIS < 10) Well this should actually be: #if defined(_BSD) && !defined(__APPLE__) && !defined(__FreeBSD__) || \ (defined(__FreeBSD__) && __FreeBSD_version < 500000) || \ (defined(HOST_SOLARIS) && HOST_SOLARIS < 10) if it ever was going to be merged back. (wrongly excluded non-FreeBSD BSDs) > > Actually it is an upstream bug, though. Nah, the parens there are okay... (|| binds less than &&, i.e. 1 || 0 && 0 evaluates to 1.) On another note, am i the only one seeing those -kernel-kqemu problems? thanx, Juergen