From owner-freebsd-bugs@FreeBSD.ORG  Mon Apr  9 14:20:18 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 476A4106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  9 Apr 2012 14:20:18 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 327D78FC12
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  9 Apr 2012 14:20:18 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q39EKIQK022250
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 9 Apr 2012 14:20:18 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q39EKIK5022249;
	Mon, 9 Apr 2012 14:20:18 GMT (envelope-from gnats)
Date: Mon, 9 Apr 2012 14:20:18 GMT
Message-Id: <201204091420.q39EKIK5022249@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/166706: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2012 14:20:18 -0000

The following reply was made to PR kern/166706; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/166706: commit references a PR
Date: Mon,  9 Apr 2012 14:17:32 +0000 (UTC)

 Author: jilles
 Date: Mon Apr  9 14:17:22 2012
 New Revision: 234057
 URL: http://svn.freebsd.org/changeset/base/234057
 
 Log:
   sem_open: Make sure to fail an O_CREAT|O_EXCL open, even if that semaphore
   is already open in this process.
   
   If the named semaphore is already open, sem_open() only increments a
   reference count and did not take the flags into account (which otherwise
   happens by passing them to open()). Add an extra check for O_CREAT|O_EXCL.
   
   PR:		kern/166706
   Reviewed by:	davidxu
   MFC after:	10 days
 
 Modified:
   head/lib/libc/gen/sem_new.c
 
 Modified: head/lib/libc/gen/sem_new.c
 ==============================================================================
 --- head/lib/libc/gen/sem_new.c	Mon Apr  9 14:16:24 2012	(r234056)
 +++ head/lib/libc/gen/sem_new.c	Mon Apr  9 14:17:22 2012	(r234057)
 @@ -162,10 +162,16 @@ _sem_open(const char *name, int flags, .
  	_pthread_mutex_lock(&sem_llock);
  	LIST_FOREACH(ni, &sem_list, next) {
  		if (strcmp(name, ni->name) == 0) {
 -			ni->open_count++;
 -			sem = ni->sem;
 -			_pthread_mutex_unlock(&sem_llock);
 -			return (sem);
 +			if ((flags & (O_CREAT|O_EXCL)) == (O_CREAT|O_EXCL)) {
 +				_pthread_mutex_unlock(&sem_llock);
 +				errno = EEXIST;
 +				return (SEM_FAILED);
 +			} else {
 +				ni->open_count++;
 +				sem = ni->sem;
 +				_pthread_mutex_unlock(&sem_llock);
 +				return (sem);
 +			}
  		}
  	}
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"