From owner-cvs-all@FreeBSD.ORG Wed Aug 6 22:22:36 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB16C106574C; Wed, 6 Aug 2008 22:22:36 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EE8BA8FC08; Wed, 6 Aug 2008 22:22:35 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m76MMZGt013173; Wed, 6 Aug 2008 22:22:35 GMT (envelope-from imp@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m76MMZXP013172; Wed, 6 Aug 2008 22:22:35 GMT (envelope-from imp@repoman.freebsd.org) Message-Id: <200808062222.m76MMZXP013172@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to imp@repoman.freebsd.org using -f From: Warner Losh Date: Wed, 6 Aug 2008 22:22:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 22:22:37 -0000 imp 2008-08-06 22:22:27 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed.c if_ed_pccard.c Log: SVN rev 181351 on 2008-08-06 22:22:27Z by imp When the miibus for the AX88x90 or TC5299J cards fails to attach, we would call ed_release_resources() when we should have called ed_detach() to properly undo the effects of prior calls to ed_attach(). This would leave a stray ed interface ifnet alive in the system, which was, well, bad, since we called if_free() on the underlying memory... Fix the ed_detach routine to cope being called in this context now. This should never come up because the miibus is always there. Except for now when it seems to be failing for reasons unknown... That's a different bug that hits at least ed, xl, dc and fxp... Revision Changes Path 1.272 +9 -7 src/sys/dev/ed/if_ed.c 1.115 +1 -1 src/sys/dev/ed/if_ed_pccard.c