Date: Wed, 30 Aug 2017 11:34:17 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448936 - in head/cad/stepcode: . files Message-ID: <20170830093417.qokiduaqykwkwmgz@ivaldir.net> In-Reply-To: <20170830093100.GA32914@FreeBSD.org> References: <201708291936.v7TJaH4W097098@repo.freebsd.org> <20170830093100.GA32914@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dpkcjxlcburqaapy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 30, 2017 at 09:31:00AM +0000, Alexey Dokuchaev wrote: > On Tue, Aug 29, 2017 at 07:36:16PM +0000, Kurt Jaeger wrote: > > New Revision: 448936 > > URL: https://svnweb.freebsd.org/changeset/ports/448936 > >=20 > > Log: > > cad/stepcode: Fix portlint issues > > =20 > > PR: 221835 > > ... > > CMAKE_ARGS+=3D -DSC_INSTALL_PREFIX=3D${PREFIX} \ > > -DSC_BUILD_TYPE=3DRelease > > + > > +MANDIRS=3D ${PREFIX}/man >=20 > What does this variable do? I don't see it referenced anywhere. Looks > like someone tried to play pass MAN_DIR down to cmake, but failed to do > it properly (see below). This is used for auto compression of the manpages, see bsd.port.mk In this case MANDIRS is completly useless as it is already default >=20 > > @@ -0,0 +1,11 @@ > > +--- doc/CMakeLists.txt.orig 2017-08-29 15:56:46 UTC > > ++++ doc/CMakeLists.txt > > +@@ -4,7 +4,7 @@ set(sc_MANS > > + ) > > +=20 > > + if(NOT DEFINED MAN_DIR) > > +- set(MAN_DIR share/man) > > ++ set(MAN_DIR man) > > + endif(NOT DEFINED MAN_DIR) >=20 > Why to patch it when you can pass MAN_DIR via CMAKE_ARGS (together with > other values)? +1 Bapt --dpkcjxlcburqaapy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlmmhpkACgkQY4mL3PG3 PloUZBAAyaZl0IKrE1XKvC0/efyaRtxBWbO+fWHTaObgdXNxqh0humADmAtzEKyR Lb8CdQ639U53nTRJGINN/bnrURqo69EF1UfDHe0vhpVECpi9OHg8LJbYfRjA7vBa 54S53pAD3kT6DoWmsafqA/4+vbXgxoIWIHU3nGWWxDnKSUYyd3AplSdAlR1ltDdF lOcZiyOEDAZ0t3u3gzcrGerxjpts3/yiRL9Tmk4ZvsBfm0yI+nSArg0dm202wosN WlQUXkaW3NNjyUmeorv5ELs3tWawKNmwVrwBAQxC/XlTk54B2zwM3qb838MTTBRN 5ItjdxCjtR3SDAdUDLT9rhYc0fqGa5WXCRq67Z19zuq5iZkzuXjnN8x4yRExhG2L mk0wsFUVsZlleY7ZMjh6BUjrbMMiqXFpxOXMmlqPknIVly65rqWJuVY1CsbFeiq3 n22RtOCY7soBqqbod8etObdT+rzx9RtMwsytoi5S1EqTi3Gws+3Y6PnuvCdRfBI1 NG500V8YWcPHsV1zaKL9ivmtIDbPBc6syQoSmBx/YWLxitIU/FvoAd1N1AvtXOZt Fbyup7Ox6pCZ6Yt/WooYHrx6q26Rqj24jTuqOHdPpDLoQO9Alqo5Gnq/zD38JE/e YWTP1fwtyeOFs8MLHm3HMZXbVcdwR0KycuAd811DmaVSowB+KEo= =5spF -----END PGP SIGNATURE----- --dpkcjxlcburqaapy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170830093417.qokiduaqykwkwmgz>