Date: Tue, 04 Feb 2020 11:05:11 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 243864] emulators/open-vm-tools-nox11: fails to build after r357287 and/or r357403 Message-ID: <bug-243864-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243864 Bug ID: 243864 Summary: emulators/open-vm-tools-nox11: fails to build after r357287 and/or r357403 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: jpaetzel@FreeBSD.org Reporter: brigadir15@gmail.com Assignee: jpaetzel@FreeBSD.org Flags: maintainer-feedback?(jpaetzel@FreeBSD.org) Created attachment 211338 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D211338&action= =3Dedit Remove the VDESC_NOMAP_VPP and VDESC_VPP_WILLRELE flags I'm trying to build emulators/open-vm-tools-nox11 on FreeBSD 13.0-CURRENT r357195 with /usr/src updated to r357494: # cd /usr/ports/emulators/open-vm-tools-nox11 # make build ... vnops.c:536:31: error: use of undeclared identifier 'VDESC_NOMAP_VPP' !(descp->vdesc_flags & VDESC_NOMAP_VPP) && ^ vnops.c:543:32: error: use of undeclared identifier 'VDESC_VPP_WILLRELE' if (descp->vdesc_flags & VDESC_VPP_WILLRELE) { ^ 2 errors generated ... The first error is caused by r357287[1] which removed the VDESC_NOMAP_VPP f= lag. The second one -- by r357403[2] which removed the VDESC_VPP_WILLRELE flag. I picked the changes made in those revisions in file sys/fs/nullfs/null_vno= ps.c and applied them to the port's file modules/freebsd/vmblock/vnops.c using define-guards. But, because neither r357287, nor r357403 changed the __FreeBSD_version, I have to use `#if __FreeBSD_version < 1300076` to be ab= le to build the port on FreeBSD 13.0-CURRENT r357195 (which is 1300076; since r356511[3]). Therefore, the patch I attached may not be completely correct= if the removed flags somehow are in use between r356511 and r357287. Please review. [1] https://svnweb.freebsd.org/base?view=3Drevision&revision=3D357287 [2] https://svnweb.freebsd.org/base?view=3Drevision&revision=3D357403 [3] https://svnweb.freebsd.org/base?view=3Drevision&revision=3D356511 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243864-7788>