From owner-cvs-src@FreeBSD.ORG  Wed Apr 30 23:58:18 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BCDA937B401; Wed, 30 Apr 2003 23:58:18 -0700 (PDT)
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CA48343F93; Wed, 30 Apr 2003 23:58:17 -0700 (PDT)
	(envelope-from mark@grondar.org)
Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1])
	by storm.FreeBSD.org.uk (8.12.7/8.12.7) with ESMTP id h416wGSQ082515;
	Thu, 1 May 2003 07:58:16 +0100 (BST)
	(envelope-from mark@grondar.org)
Received: (from Ugrondar@localhost)h416wGeH082514;
	Thu, 1 May 2003 07:58:16 +0100 (BST)
X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to
	mark@grondar.org using -f
Received: from grondar.org (localhost [127.0.0.1])h416xmQL023287;
	Thu, 1 May 2003 07:59:48 +0100 (BST)	(envelope-from mark@grondar.org)
From: Mark Murray <mark@grondar.org>
Message-Id: <200305010659.h416xmQL023287@grimreaper.grondar.org>
To: Mike Barcroft <mike@FreeBSD.org>
In-Reply-To: Your message of "Wed, 30 Apr 2003 18:43:51 EDT."
             <20030430184351.B31859@espresso.bsdmike.org> 
Date: Thu, 01 May 2003 07:59:48 +0100
Sender: mark@grondar.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2003 06:58:19 -0000

Mike Barcroft writes:
> Is it really useful to #ifdef critical sections of code.  This thing
> isn't going to compile without asm extentions from the compiler.  So
> really you just turn compile errors into link error.  Not very helpful
> IMO.

Yes. Lint(1) does not understand GCCisms.

> Also, you added an used #else clause near the top.

EPARSE ? :-)

M
--
Mark Murray
iumop ap!sdn w,I idlaH