From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 3 01:20:01 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2594B1065674 for ; Tue, 3 Mar 2009 01:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 017308FC13 for ; Tue, 3 Mar 2009 01:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n231K0t0012918 for ; Tue, 3 Mar 2009 01:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n231K0mK012917; Tue, 3 Mar 2009 01:20:00 GMT (envelope-from gnats) Resent-Date: Tue, 3 Mar 2009 01:20:00 GMT Resent-Message-Id: <200903030120.n231K0mK012917@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Navdeep Parhar Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6FF11065678 for ; Tue, 3 Mar 2009 01:13:13 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 95DCA8FC1B for ; Tue, 3 Mar 2009 01:13:13 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n231DDJY070368 for ; Tue, 3 Mar 2009 01:13:13 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n231DDAS070367; Tue, 3 Mar 2009 01:13:13 GMT (envelope-from nobody) Message-Id: <200903030113.n231DDAS070367@www.freebsd.org> Date: Tue, 3 Mar 2009 01:13:13 GMT From: Navdeep Parhar To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/132271: puc support for a generic card X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 01:20:01 -0000 >Number: 132271 >Category: kern >Synopsis: puc support for a generic card >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 03 01:20:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Navdeep Parhar >Release: HEAD 8-CURRENT >Organization: Chelsio Communications >Environment: FreeBSD pepper 8.0-CURRENT FreeBSD 8.0-CURRENT #6: Mon Mar 2 12:43:40 PST 2009 root@pepper:/usr/obj/usr/src/sys/GENERIC amd64 >Description: I sent a patch to freebsd-hackers that lets puc recognize and work with a no-brand 1 port serial card. Mark Linimon suggested that I file a PR so that it doesn't get lost. This is that PR. Here is the original message: http://lists.freebsd.org/pipermail/freebsd-hackers/2009-March/027862.html >How-To-Repeat: >Fix: Patch attached with submission follows: diff -r 025cb00d19d7 sys/dev/puc/puc.c --- a/sys/dev/puc/puc.c Sat Feb 28 12:42:37 2009 -0800 +++ b/sys/dev/puc/puc.c Mon Mar 02 12:55:26 2009 -0800 @@ -440,9 +440,6 @@ sc->sc_dev = dev; sc->sc_cfg = cfg; - /* We don't attach to single-port serial cards. */ - if (cfg->ports == PUC_PORT_1S || cfg->ports == PUC_PORT_1P) - return (EDOOFUS); error = puc_config(sc, PUC_CFG_GET_NPORTS, 0, &res); if (error) return (error); diff -r 025cb00d19d7 sys/dev/puc/pucdata.c --- a/sys/dev/puc/pucdata.c Sat Feb 28 12:42:37 2009 -0800 +++ b/sys/dev/puc/pucdata.c Mon Mar 02 12:55:26 2009 -0800 @@ -761,6 +761,12 @@ PUC_PORT_2P, 0x10, 8, 0, }, + { 0x9710, 0x9835, 0x1000, 1, + "NetMos NM9835 based 1-port serial", + DEFAULT_RCLK, + PUC_PORT_1S, 0x10, 4, 0, + }, + { 0x9710, 0x9835, 0xffff, 0, "NetMos NM9835 Dual UART and 1284 Printer port", DEFAULT_RCLK, >Release-Note: >Audit-Trail: >Unformatted: