Date: Mon, 2 Sep 2013 14:03:50 -0600 From: "Justin T. Gibbs" <gibbs@freebsd.org> To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com> Cc: "freebsd-xen@freebsd.org" <freebsd-xen@freebsd.org> Subject: Re: blkback making assumptions about the id of the requests Message-ID: <D8D631B6-3DB4-4F7C-A0B0-590C7B5FA250@freebsd.org> In-Reply-To: <5224D1DE.8080906@citrix.com> References: <5224D1DE.8080906@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 2, 2013, at 11:58 AM, Roger Pau Monn=E9 <roger.pau@citrix.com> = wrote: > Hello, >=20 > While playing with driver domains using FreeBSD I've found out that > blkback in FreeBSD makes assumptions about the id of a request instead > of actually using the id of the request on the shared ring. This seems > wrong to me, since a frontend might choose whatever ids it like for = the > requests (like using 100-131 instead of 0-31). The patch attached = fixes > it by copying the id from the request on the ring to blkback internal > request structure. >=20 > Roger. It looks to me like the id is set in xbb_dispatch_io(). Why it is done = there and not earlier, I don't recall. -- Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D8D631B6-3DB4-4F7C-A0B0-590C7B5FA250>