From owner-cvs-all@FreeBSD.ORG Sun Oct 8 08:50:43 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41FD116A403; Sun, 8 Oct 2006 08:50:43 +0000 (UTC) (envelope-from alex@foxybanana.com) Received: from ultrasuede.reed.edu (ultrasuede.reed.edu [134.10.2.46]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDBCD43D62; Sun, 8 Oct 2006 08:50:35 +0000 (GMT) (envelope-from alex@foxybanana.com) Received: from Laptop.mine.box (c038h213.dorm.reed.edu [134.10.38.213]) by ultrasuede.reed.edu (8.13.7/8.13.7) with ESMTP id k988oXjJ017659 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT); Sun, 8 Oct 2006 01:50:33 -0700 Received: from localhost (localhost [127.0.0.1]) by Laptop.mine.box (8.13.6/8.13.6) with ESMTP id k988ndp6086544; Sun, 8 Oct 2006 01:49:39 -0700 (PDT) (envelope-from alex@Laptop.mine.box) Message-Id: <200610080849.k988ndp6086544@Laptop.mine.box> From: Alexander Botero-Lowry To: Erwin Lansing In-reply-to: <20061008084005.GM10626@droso.net> References: <200610072356.k97NuAW4051992@repoman.freebsd.org> <20061008084005.GM10626@droso.net> Comments: In-reply-to Erwin Lansing message dated "Sun, 08 Oct 2006 10:40:06 +0200." Date: Sun, 08 Oct 2006 01:49:39 -0700 Sender: alex@foxybanana.com X-Scanned-By: MIMEDefang 2.57 on 134.10.2.46 Cc: cvs-ports@FreeBSD.org, Pav Lucistnik , alex@Laptop.mine.box, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/science/py-scipy Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2006 08:50:43 -0000 > > On Sat, Oct 07, 2006 at 11:56:10PM +0000, Pav Lucistnik wrote: > > pav 2006-10-07 23:56:10 UTC > >=20 > > FreeBSD ports repository > >=20 > > Modified files: > > science/py-scipy Makefile=20 > > Log: > > - Fix OPTIONS > > =20 > > | DISTNAME=3D SciPy_complete-${PORTVERSION} > > | +LATEST_LINK=3D py-${PORTNAME} > > | =20 > > How does setting LATEST_LINK fix OPTIONS? > With ports that include a PKGNAME_PREFIX it is required. Otherwise you get an error like: If you attempt to run make config for a port with ${PKGNAMEPREFIX} defined, the make config process will error out with: ===> Using wrong configuration file /path/options/file The solution is to define LATEST_LINK to be prefix-${PORTNAME}, but this should be done internally. The problem is because ${_OPTIONFILE} is staticially defined (by using echo), before the various bsd.*.mk files that set the appropriate PKGNAME_PREFIXs like PYTHON_PKGNAMEPREFIX. So part of the options bit is looking for a file with the prefix and part is looking for a packagename without it, and it gets itself quite upset. I have a more detailed and accurate explanation of this problem in an email somewhere, I will try and find it. (I submitted a PR where LATEST_LINK was set and the committer removed it and broke the port, so I went and documented the problem.) Alex > -erwin > > --=20 > Erwin Lansing http://droso.org > Security is like an onion. (o_ _o) > It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org > And it makes you cry. <____) (____> erwin@aauug.dk > > --Ftt3SnK74BQwCaZF > Content-Type: application/pgp-signature > Content-Disposition: inline > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.5 (FreeBSD) > > iD8DBQFFKLllqy9aWxUlaZARAvERAKDykR8J4jv2nR6MFuMdxsfro0myeACgtBi+ > Fk+O0bsTg6BUfnRDNY9zqw4= > =yH2h > -----END PGP SIGNATURE----- > > --Ftt3SnK74BQwCaZF-- > > --DSPAM_MULTIPART_EX-726 > Content-Type: text/plain > X-DSPAM-Signature: 4,4528b9a57261120810437 > > !DSPAM:4,4528b9a57261120810437! > --DSPAM_MULTIPART_EX-726-- > >