From nobody Thu May 23 16:05:57 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlY1m72ZZz5KVWx; Thu, 23 May 2024 16:06:04 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlY1m4NcNz4ZQZ; Thu, 23 May 2024 16:06:04 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.18.1/8.18.1) with ESMTP id 44NG61QV058851; Thu, 23 May 2024 11:06:01 -0500 (CDT) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1716480361; bh=zw+V+cycE0Ib9mZ2M8d/0AKLRwVuUsAwi6n+t9dGmLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qzg/G9gkbHLwH6xIPy6SP+a4rMMmk51+W4ns5RjOMWMcCmZYQviqcRpxQy/tQgCVr uhZvaZozn59pKf9jpLRf0T3YNRrTyDI85BsCueJAuMnEVMPH+hHQwdLOoK+9zUESWw RnGU9vI61LjSLrybY5HiRAFfB4MxyEgPVGr5Fb5tw3J8vRR/QHd6Qey24yzW9U36++ zKjwtEQkE4rPpOIP+NTo0KNuBiBNdpVwhqfoY+1lg1WGeoVkAVsEVh7uv/ozh9h1/2 c9frucS5iKeNp4WF6QrjXvb737quytxZRkT36zk4BxYCPx41EqgoJ25rpgV5e0KCg0 cOvCbtSzVDX7g== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id loGzHmlpT2bh5QAAs/W3XQ (envelope-from ); Thu, 23 May 2024 11:06:01 -0500 From: Mike Karels To: Baptiste Daroussin Cc: Michael Osipov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() Date: Thu, 23 May 2024 11:05:57 -0500 X-Mailer: MailMate (1.14r6030) Message-ID: <1AE302C8-5EED-4644-8900-6D8B91326183@karels.net> In-Reply-To: References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Queue-Id: 4VlY1m4NcNz4ZQZ On 23 May 2024, at 10:14, Baptiste Daroussin wrote: > On Thu 23 May 14:34, Michael Osipov wrote: >> On 2024-05-23 14:10, Mike Karels wrote: >>> On 22 May 2024, at 10:07, Baptiste Daroussin wrote: >>> >>>> On Fri 03 May 07:40, Michael Osipov wrote: >>>>> The branch main has been updated by michaelo: >>>>> >>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Daa48259f337100e79933= d660fec8856371f761ed >>>>> >>>>> commit aa48259f337100e79933d660fec8856371f761ed >>>>> Author: Michael Osipov >>>>> AuthorDate: 2024-04-15 11:05:17 +0000 >>>>> Commit: Michael Osipov >>>>> CommitDate: 2024-05-03 07:38:55 +0000 >>>>> >>>>> periodic.conf: remove long deprecated security_daily_compat_va= r() >>>>> >>>>> This function is documented to be gone in after 11. Time to re= move this >>>>> compat shim. >>>>> >>>>> PR: 275296 >>>>> Reviewed by: jrm (mentor) >>>>> MFC after: 1 month >>>>> Differential Revision: https://reviews.freebsd.org/D44796 >>>> >>>> this broke pkg's periodic script, I would have appreciated a heads u= p to give me >>>> time to prepare a release compatible prior this commit. >>>> >>>> This also breaks some ports. >>>> >>>> Bapt >>> >>> This produces almost a dozen failure messages in the daily security e= mail. >>> Given that the deprecated function was still in use, it should not be= removed. >>> Michael, please revert this. >> >> Salut Baptiste, >> Hi Mike, >> >> this is surprising that is it still in use although clear marked as >> deprecated after 11. Though, Baptiste has pushed a new pkg release yes= terday >> [1] and only main is affected, do you still prefer to revert this comm= it >> (for now)? >> >> @bapt, can you name the affected ports and report a PR, so we can trac= k >> them? >> > > This was in use beside the deprecation, because pkg for one is supposed= to > support as many version of freebsd as possible so we had to keep the de= precation > notice. > > I have released a new version of pkg without it and merged that version= in > quarterly branches, so even if it gets MFCed we should be safe. > > I was scared more ports where keeping for the same reason the deprecate= d code, I > span the ports tree itself and found one port which I fixed straight aw= ay, I > also did a deep analysis of the any port which plist contains etc/perio= dic, > I extracted all their sources and I found nothing. > > so I think we are safe now. I don't think we should revert. > > Best regards, > Bapt OK, I'll withdraw my request to revert if we're confident that there are = no stragglers. Mike