From owner-cvs-all@FreeBSD.ORG Tue Dec 12 18:42:31 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EC5D516A49E; Tue, 12 Dec 2006 18:42:31 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0AEFA43D88; Tue, 12 Dec 2006 18:37:37 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (wx8r48hu5jz7ehk3@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id kBCIcRmk061068; Tue, 12 Dec 2006 10:38:27 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id kBCIcP9g061067; Tue, 12 Dec 2006 10:38:25 -0800 (PST) (envelope-from jmg) Date: Tue, 12 Dec 2006 10:38:25 -0800 From: John-Mark Gurney To: Luigi Rizzo Message-ID: <20061212183825.GF781@funkthat.com> References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> <20061212062445.A61903@xorpc.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061212062445.A61903@xorpc.icir.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: Luigi Rizzo , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, imp@FreeBSD.org, ticso@cicely.de Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 18:42:32 -0000 Luigi Rizzo wrote this message on Tue, Dec 12, 2006 at 06:24 -0800: > On Tue, Dec 12, 2006 at 03:17:59PM +0100, Bernd Walter wrote: > > On Tue, Dec 12, 2006 at 05:57:56AM -0800, Luigi Rizzo wrote: > ... > > > then i suppose the proper fix is to revert to m_copy() and > > > work on if_simloop() so that 1. it handles a readonly chain, and > > > 2. when doing so, it passes up a properly aligned packet... > > > > Can't comment on this, as I don't have enough knowledge about network > > code. > > According to the xscale report it was likely never properly aligned, > > the alignment obviously just moved with your change. > > > > > however note that there is already some code in net/if_loop.c::if_simloop(), > > > just that it uses this: > > > > > > #if defined(__ia64__) || defined(__sparc64__) > ... > > > to detect whether the architecture is alignment-sensitive. > > > Is there any other identifier that we can use to check ? > > > > I wonder how many of these are missing __arm__? > > and this is why i wonder if there is a generic identifier > that we can use to provide alignment. How about? #define __NO_STRICT_ALIGNMENT It's already defined for amd64 and i386, so all you have to do it test that it isn't defined... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."