From owner-freebsd-fs@FreeBSD.ORG Tue Jan 3 09:50:11 2012 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48363106564A for ; Tue, 3 Jan 2012 09:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 36A498FC0C for ; Tue, 3 Jan 2012 09:50:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q039oBie095945 for ; Tue, 3 Jan 2012 09:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q039oBvC095944; Tue, 3 Jan 2012 09:50:11 GMT (envelope-from gnats) Date: Tue, 3 Jan 2012 09:50:11 GMT Message-Id: <201201030950.q039oBvC095944@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2012 09:50:11 -0000 The following reply was made to PR conf/116931; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, phk@critter.freebsd.dk Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) Date: Tue, 3 Jan 2012 01:41:28 -0800 The attached patch looks ok. The only suggestion that I have is that since you're grabbing the fs field from /etc/fstab, instead of keeping a blacklist, I would just use command -v; example: $ command -v fsck_ufs; echo $? /sbin/fsck_ufs 0 $ command -v fsck_cd9660; echo $? 1 $ This would reduce the number of needed special cases in the mdconfig script. Thanks! -Garrett