From nobody Mon Mar 7 19:33:15 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C353519F5D53 for ; Mon, 7 Mar 2022 19:33:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC7sl2jTFz5979 for ; Mon, 7 Mar 2022 19:33:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 38A2964E2 for ; Mon, 7 Mar 2022 19:33:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 227JXFv0000160 for ; Mon, 7 Mar 2022 19:33:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 227JXF2m000159 for bugs@FreeBSD.org; Mon, 7 Mar 2022 19:33:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262406] [re] if_re doesn't generate MAC address if hardware has none Date: Mon, 07 Mar 2022 19:33:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: evgeni@debian.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646681595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kBthhxOWsgkfjgsVaSkoMAU5pb38Q2fxzPbg9w2ceu0=; b=wsCYkDApodrm9GWwUn5omlqvh4dKxqwHg2cpHyWGVDWTflEf/f6Cvk5LibVrp3yoHh/HYA DhJYd3aY8hllxrZ8cvXLw3B/NbzbKAyirS+qnTM4yPQGPrYnLzXLIui282cLWjH8Qrd6PM dVm3b2gOHWKnhJZOIoAb0eO8zhsgplInjTETHGD3r/lapFRHzZF0mq+Au23VvhrMaQaWvE dUgBvLj1T7917vFTl2xrev98GpZo2lyZwRlAgzoD9lLadt7I3GD+WB1uCqYRLh6rK+5s+j McNpdD96z2NBB7rdD8iUeQugXu2EBb2/HqTsy/TdMmT3lhi5zXo1XsOzVzYvpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646681595; a=rsa-sha256; cv=none; b=YA/QWp80GrLhwpz9hadpHu10qtP7tFvWTRvZB0wndqMBqstTd84Xja87/i7jZvxb4uu/Cj ymH9QseRk37y4cVt1rdM6i0Pu3VuOzv0Zel2kKhoh1jiOXs6xdg2/dLxQr0TRi/L77ZcUn HlX22kMxI+E9P7tee4CPrOaVIKYmXXO5//fWo/9r6Xugi7xr2cu2G93n4Wz0oLGWR3aHhH WrXchLqp+iEmePHlnCpKJ8FQ3B8TEPvSg/AyPze8KqFp1tu2uj+pDmQfXXWoAhBfqtOY0a 5tDocrSoUqGIV0v9fqnekuWaWOGBwXfN2g6h0Ct/8+x0KVwhZ18HKTCkt3Uylg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262406 Bug ID: 262406 Summary: [re] if_re doesn't generate MAC address if hardware has none Product: Base System Version: 13.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: evgeni@debian.org Ohai, there exists hardware (like [1]) that has no ethernet address burned into t= he EEPROM. Loading if_re on such a HW brings the device up with '00:00:00:00:00:00' as the address, and that doesn't get you too far in a r= eal network. Other drivers use ether_gen_addr(9) in such cases, to generate an address, = and so should if_re, I think? Probably something like this (untested yet): diff --git sys/dev/re/if_re.c sys/dev/re/if_re.c index 5d1446e51ab..7905740a930 100644 --- sys/dev/re/if_re.c +++ sys/dev/re/if_re.c @@ -1676,6 +1676,11 @@ re_attach(device_t dev) goto fail; } + /* If address was not found, create one based on the hostid and nam= e. */ + if (ETHER_IS_ZERO(eaddr)) { + ether_gen_addr(ifp, eaddr); + } + /* * Call MI attach routine. */ Thanks! [1] https://www.dfrobot.com/product-2242.html --=20 You are receiving this mail because: You are the assignee for the bug.=