From owner-svn-src-head@freebsd.org Thu May 4 15:10:06 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0901CD5E4E2; Thu, 4 May 2017 15:10:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC76F308; Thu, 4 May 2017 15:10:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f52.google.com with SMTP id m123so19174061wma.0; Thu, 04 May 2017 08:10:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=B6BVvJovAcuEIliUVg2ndDeHdLk460Ia74RNaCQ24l8=; b=s1v2fuqGQ745OCvNyuzjAsogVLrU2Ox+4euBQ/W7bxmI7ZT2ful92k+jrI++Vd1BWe KuFEiuF/Gj9wfePkknPjVRV4sqLEW4o6MfJTU7FFy69GLmj25fppk9NdTNABNqZYfWkN z5D5BUJ1dKJgbC7uIhPXFROEI7/l7epCSI7Etec+z3RVusHyK/LjAN4V2jrdFRNNiL1w 57AQ8bhJa0dAuBqb8YuK4Xm07J6YxiBcg9ihQh8VuX6c1GY6l7CCPsm6Tywwe97UPa05 QPTTMtLLC6zhHMwdm9q233ekP+UZDS3oi4MPPm3hCsWsReWaj4PXPP5JrjMfWa3PB473 qu/g== X-Gm-Message-State: AODbwcAich5ct/CQVxwulIdQX28BVwpRb4KZZmQN5yfHCQOgLntRc3W7 s1ZIcmVHJc0MwyaOEb4= X-Received: by 10.28.55.3 with SMTP id e3mr2313636wma.7.1493910603437; Thu, 04 May 2017 08:10:03 -0700 (PDT) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com. [74.125.82.48]) by smtp.gmail.com with ESMTPSA id u4sm1735622wmu.0.2017.05.04.08.10.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 May 2017 08:10:03 -0700 (PDT) Received: by mail-wm0-f48.google.com with SMTP id 142so14671094wma.1; Thu, 04 May 2017 08:10:03 -0700 (PDT) X-Received: by 10.80.135.214 with SMTP id 22mr2227783edz.124.1493910603185; Thu, 04 May 2017 08:10:03 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Thu, 4 May 2017 08:10:02 -0700 (PDT) In-Reply-To: References: <201704300208.v3U28lZo093446@repo.freebsd.org> From: Conrad Meyer Date: Thu, 4 May 2017 08:10:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r317600 - in head/sys: amd64/vmm/amd modules/vmm To: Anish Gupta Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 May 2017 15:10:06 -0000 On Thu, May 4, 2017 at 7:58 AM, Conrad Meyer wrote: > On Sat, Apr 29, 2017 at 7:08 PM, Anish Gupta wrote: >> Author: anish >> Date: Sun Apr 30 02:08:46 2017 >> New Revision: 317600 >> URL: https://svnweb.freebsd.org/changeset/base/317600 >> >> Log: >> Add AMD IOMMU/AMD-Vi support in bhyve for passthrough/direct assignment to VMs. To enable AMD-Vi, set hw.vmm.amdvi.enable=1. >> >> Reviewed by:bcr >> Approved by:grehan >> Tested by:rgrimes >> Differential Revision:https://reviews.freebsd.org/D10049 >> ... Hi Anish, One more Coverity warning that came in with this commit: In ivrs_drv.c: ivrs_hdr_iterate_tbl(), there is a check for 'ivrs_hdr->Length < 0'. However, Length has an unsigned type and cannot be negative, so the check can never be true. (CID: 1374746.) Best, Conrad