From owner-freebsd-current@FreeBSD.ORG  Thu May 19 20:23:46 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C97416A4CF; Thu, 19 May 2005 20:23:46 +0000 (GMT)
Received: from gate.bitblocks.com (bitblocks.com [209.204.185.216])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F347E43D64; Thu, 19 May 2005 20:23:43 +0000 (GMT)
	(envelope-from bakul@bitblocks.com)
Received: from bitblocks.com (localhost [127.0.0.1])
	by gate.bitblocks.com (8.13.3/8.13.1) with ESMTP id j4JKNVLw038968;
	Thu, 19 May 2005 13:23:32 -0700 (PDT)
	(envelope-from bakul@bitblocks.com)
Message-Id: <200505192023.j4JKNVLw038968@gate.bitblocks.com>
To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
In-reply-to: Your message of "Thu, 19 May 2005 12:25:55 PDT."
             <428CE843.7040705@savvis.net> 
Date: Thu, 19 May 2005 13:23:31 -0700
From: Bakul Shah <bakul@BitBlocks.com>
cc: peadar@freebsd.org
cc: Matti Saarinen <mjsaarin@cc.helsinki.fi>
cc: Scot Hetzel <swhetzel@gmail.com>
cc: freebsd-current@freebsd.org
Subject: Re: CURRENT: ifconfig tap0 results in core dump 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2005 20:23:46 -0000

i don't know about the if_tap.c fix but the following at
fixes the segfault in ifconfig.c without any information loss
as far as i can tell.

Index: ifconfig.c
===================================================================
RCS file: /home/ncvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.112
diff -w -u -b -r1.112 ifconfig.c
--- ifconfig.c	8 Apr 2005 21:37:41 -0000	1.112
+++ ifconfig.c	19 May 2005 20:14:02 -0000
@@ -869,7 +869,7 @@
 		if (allfamilies) {
 			const struct afswtch *p;
 			p = af_getbyfamily(info.rti_info[RTAX_IFA]->sa_family);
-			if (p != NULL)
+			if (p != NULL && p->af_status != NULL)
 				p->af_status(s, &info);
 		} else if (afp->af_af == info.rti_info[RTAX_IFA]->sa_family)
 			afp->af_status(s, &info);