From owner-svn-src-head@freebsd.org Thu Feb 15 06:24:30 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 737FAF00B9F for ; Thu, 15 Feb 2018 06:24:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E984E84D10 for ; Thu, 15 Feb 2018 06:24:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id t126so4480244iof.4 for ; Wed, 14 Feb 2018 22:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=a3CIRNYArpEDA0/ijtxxsKh/DUxNYxlsY/3QMZmhVgM=; b=At9s+Ew1lOr2eAGKJtQY35P43mfzDCTaTjf4Iqw6oLwIonyl0dv0xkmbj9Ax4odSLk EOC2dxcmu1fIP/3b8CdZcrBI36ED/1kDwDM9ic5EEHrTvgLU9at5EFJLBlEjtH15PQod igvPjT4lsD+/SaKDGkKsCZ9qTWGn8cIJ02mDXkLQsJTNRWwqXT/Mj0QJbKVAZd0sfaIh EDzaJfPNF0R1BhRIJ3xKXqb5Kfls0i31ZXbwB6PxxTabDuKGF4ygJWpHU4H3nmftfDf+ 77yyCv/vi596GhLQkLHPxnrgCX8wIFGWmJTBiNukB1C6qrk0f+VBuIKV3fwgG7gOda6x 47og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=a3CIRNYArpEDA0/ijtxxsKh/DUxNYxlsY/3QMZmhVgM=; b=gnIPESG9hGQmTRTpTP0PafqgWju82LnbW8mMeKrcbVb+wdSFofqFVPLsalvKutTQE/ RQoleXlZ1gj+cBEiEBxBDmtNybV25cgugcwSkhR70QHmH3zXQR5C7QmoKv/euKce6W0C emk85BVugTjNzOesmsMLw/oOTEQbMgpp/iVRNYESAqHUe9Jh4JF1LWQomHxbw70XPiC6 P3fjS2KY8LxpTmvOBcG/5ToacCXinJZ0W9kNC11k2quRcFV6eh5XBltdhVB+2Bnj5A9M V2qjIr4+q14QCxdYU1GT/2UtyeBkt9CpIRtdEdbYINZoBNhCi/b6HjtiTy9ABLkxlMrT aQ9w== X-Gm-Message-State: APf1xPBPt6xa+RU03Q5fWtFYJO6fGBt0S92xSoYLpcLeL02yDQutSxzT As8X39Kp2ty/tTPRa2j/GsAfh4C2Mx+i3AbceM5xYg== X-Google-Smtp-Source: AH8x224r2pHl2tV6R4/UIpdO9ib8/tYZ5CTT07yjz4k9JFZBLdlrgIYFvWu+HxgyDmjw2D6n0odSYhMy/XGz4D47hQg= X-Received: by 10.107.232.7 with SMTP id f7mr691289ioh.130.1518675869088; Wed, 14 Feb 2018 22:24:29 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Wed, 14 Feb 2018 22:24:28 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:18a2:a4f7:170:8dd9] In-Reply-To: References: <201802150322.w1F3Mrie018786@repo.freebsd.org> From: Warner Losh Date: Wed, 14 Feb 2018 23:24:28 -0700 X-Google-Sender-Auth: HoMnuRv9rVfnlFc6xarkjfCdjyc Message-ID: Subject: Re: svn commit: r329296 - head/sbin/devd To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 06:24:30 -0000 On Wed, Feb 14, 2018 at 8:51 PM, Eitan Adler wrote: > On 14 February 2018 at 19:48, Warner Losh wrote: > > > > > > On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh wrote: > >> > >> > >> > >> On Feb 14, 2018 8:23 PM, "Eitan Adler" wrote: > >> > >> Author: eadler > >> Date: Thu Feb 15 03:22:53 2018 > >> New Revision: 329296 > >> URL: https://svnweb.freebsd.org/changeset/base/329296 > >> > >> Log: > >> devd: don't pass &fds in useless parameters to select(2) > >> > >> select(2) should be declared as restrict. In addition the only fd in > >> the fdset is open O_RDONLY, and it's not a socket that can provide OOB > >> notifications, > >> > >> Reviewed by: ian, imp, vangyzen > >> > >> > >> Don't put my name on this. I specifically and clearly objected to the > >> change anf tld yoy not to do it. > > > > > > Stupid phone... > > > > I specifically objected to this change. I said not to make it because it > > wasn't necessary. You did it any way. Don't put "reviewed by" for that. > Put > > "objected to but I did it anyway by: imp" > > hrm.. rereading the thread I think I missed your original email. Only > comment I saw was "poll is a better interface". Sorry for mis-stating > your opinion. > Yea. It was more of a "don't change it, since it's fine now" and then the "poll" comment was "better to just change to a better interface." > FTR I'd like to fix the declaration of select(2) anyways. That's unlikely to end well... I wish you luck... The pattern I used in devd for select was nearly universal a decade ago... Maybe things have changed... Warner