From owner-freebsd-ports@FreeBSD.ORG Fri Oct 24 17:15:05 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E055416A4B3; Fri, 24 Oct 2003 17:15:05 -0700 (PDT) Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4D8543FB1; Fri, 24 Oct 2003 17:15:04 -0700 (PDT) (envelope-from eikemeier@fillmore-labs.com) Received: from p5080ba6e.dip.t-dialin.net ([80.128.186.110] helo=fillmore-labs.com ident=4ydmzw6gpl34w59c) by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256) (Exim 4.24; FreeBSD 4.9) id 1ADC59-0002S9-DG; Sat, 25 Oct 2003 02:15:03 +0200 Message-ID: <3F99C084.4010105@fillmore-labs.com> Date: Sat, 25 Oct 2003 02:15:00 +0200 From: Oliver Eikemeier MIME-Version: 1.0 To: Adam Weinberger References: <200310241720.40898.freebsd.nospam@mekanix.dk> <3F99438A.4090902@fillmore-labs.com> <200310241752.56331.freebsd.nospam@mekanix.dk> <3F995BA9.2000003@fillmore-labs.com> <20031024183453.GQ96543@toxic.magnesium.net> In-Reply-To: <20031024183453.GQ96543@toxic.magnesium.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: eikemeier@fillmore-labs.com User-Agent: KMail/1.5.9 Organization: Fillmore Labs GmbH X-Complaints-To: abuse@fillmore-labs.com cc: Bjarne Wichmann Petersen cc: freebsd-ports@freebsd.org Subject: Re: Broken portstree? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Oct 2003 00:15:06 -0000 Adam Weinberger wrote: >>>(10.24.2003 @ 1304 PST): Oliver Eikemeier said, in 1.2K: << >> >>Newer *ever* set USE_* in /etc/make.conf or elsewhere. User settable options >>are WITH_* and WITHOUT_* >> >>every port that has USE_* as an user-settable option should be >>filed a bug report. >> >>>end of "Re: Broken portstree?" from Oliver Eikemeier << > > > I agree. I think that USE_ would have been better left for user-defines, > but that's not how history panned out. > > USE_* should be reserved for ports to define, and ports should not have > user-tunable options that begin with USE_ (or, in the ridiculous manner > of q3server-ra3 and utserver-to, DONT_USE_). Port should have all > user-definable settings as WITH_* and WITHOUT_*, and all ports that have > USE_ should be changed. Ermmn, IMO that is. > > Here is a list of ports that have user-tunable options that begin with > USE_. Note that this is a really quick and dirty list, and probably has > errors. > > # Adam > > > cad/gmsh > USE_TRIANGLE > cad/tochnog > USE_THREADS > chinese/libtabe > USE_DB2 > chinese/xcin25 > USE_DB2 > comms/ltmdm > USE_595_OBJ > devel/pear-PEAR > USE_PHPIZE > editors/staroffice60 > USE_CDROM > games/q3server-ra3 > DONT_USE_ZIP > games/tome > USE_XLIB > games/utserver-to > DONT_USE_ZIP > DO_USE_WRKSUBDIR > DO_USE_STRIP > irc/ngircd > USE_TCP_WRAPPERS > japanese/skkinput3 > USE_SKK10 > japanese/zangband > USE_Z_SCORES > mail/anubis > USE_OPENSSL > USE_GNUTLS > USE_PAM > USE_TCP_WRAPPERS > mail/mutt-devel > USE_NCURSES > USE_SLANG > math/maxima > USE_CMLCL > USE_GCL > USE_CLISP > math/spooles > USE_MPI > USE_THREADS > security/heimdal > USE_XLIB > security/isakmpd > USE_KEYNOTE > security/krb5 > USE_MIT_TARBALL > www/interchange > USE_THIS_PERL > www/lynx-current > USE_OPENSSL > www/mnogosearch > USE_OPENSSL > www/w3m > USE_OPENSSL > x11/xmotd > USE_HTML > USE_MOTIF > USE_XPM > x11-servers/XttXF86srv-common > USE_SHARED_WRKSRC Hey, USE_OPENSSL is great, you can try it with every port. The same is true for USE_MOTIF and USE_XPM. I especially like DO_USE_WRKSUBDIR, second in my list is USE_THIS_PERL. DONT_USE_THAT_PERL! Third is ifndef(DONT_USE_ZIP). My list is even longer, using egrep -r '^[ ]*\.[ ]*(el)?if.*USE_' /usr/ports/[a-z]* Ok, my preferred solution would be to feed this to portlint, hoping that this usage becomes extinct. Or should we file some PRs?