From owner-freebsd-current@FreeBSD.ORG  Sun Sep  7 22:28:37 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A78F8439;
 Sun,  7 Sep 2014 22:28:37 +0000 (UTC)
Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 873CF148F;
 Sun,  7 Sep 2014 22:28:36 +0000 (UTC)
Received: from [192.168.200.205] (unknown [50.136.155.142])
 (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 (Authenticated sender: sbruno@ignoranthack.me)
 by mail.ignoranthack.me (Postfix) with ESMTPSA id 65817192906;
 Sun,  7 Sep 2014 22:28:35 +0000 (UTC)
Subject: Re: NO INET6 warning
From: Sean Bruno <sbruno@ignoranthack.me>
Reply-To: sbruno@freebsd.org
To: Glen Barber <gjb@FreeBSD.org>
In-Reply-To: <20140907210802.GA48287@hub.FreeBSD.org>
References: <1410123815.10027.18.camel@bruno>
 <20140907210802.GA48287@hub.FreeBSD.org>
Content-Type: text/plain; charset="us-ascii"
Date: Sun, 07 Sep 2014 15:28:33 -0700
Message-ID: <1410128913.10027.19.camel@bruno>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Sep 2014 22:28:37 -0000

On Sun, 2014-09-07 at 17:08 -0400, Glen Barber wrote:
> On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote:
> > make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" line
> > 12: warning: Couldn't read shell's output for
> > "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZR-300HP/opt_inet6.h"
> > 
> > 
> > Shouldn't this cat be done in a saner way?
> > 
> 
> This is done quite often throughout the tree, and bmake(1) does not like
> it when there is no value assigned from the '!=' expansion.
> 
> The fix I've seen most commonly done is to echo a newline after the
> assignment, such as:
> 
> Index: sys/modules/if_gif/Makefile
> ===================================================================
> --- sys/modules/if_gif/Makefile	(revision 271215)
> +++ sys/modules/if_gif/Makefile	(working copy)
> @@ -9,7 +9,7 @@ KMOD=	if_gif
>  SRCS=	if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h
>  
>  .if defined(KERNBUILDDIR)
> -OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h
> +OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h; echo
>  .if empty(OPT_INET6)
>  MK_INET6_SUPPORT=no
>  .endif
> 
> Glen
> 


LGTM

sean