From owner-freebsd-acpi@FreeBSD.ORG Wed Mar 18 15:59:47 2015 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08134DA5 for ; Wed, 18 Mar 2015 15:59:47 +0000 (UTC) Received: from nm19-vm4.bullet.mail.ne1.yahoo.com (nm19-vm4.bullet.mail.ne1.yahoo.com [98.138.91.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5626ECD for ; Wed, 18 Mar 2015 15:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1426694380; bh=G63wEoQhnDhv9zhDMI92RY9uNlKMxMJ2E7pNuqpvyqY=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=oL40Me+3BSZwmn7qAVBc8XSozRs3iDIzkM0g315037blf94BcWQqE5qx/yIcSu54niQoxpjsEYIi83g1LDzBQlgT2bI8wpBLeurx+5z5N+gpWWCa4UnSM9ZrH1IXCrwNPBps82wpcXTXMDgGQ7nxCMgBHEzogQYROz7KHqgvkfg= Received: from [98.138.100.117] by nm19.bullet.mail.ne1.yahoo.com with NNFMP; 18 Mar 2015 15:59:40 -0000 Received: from [98.138.84.45] by tm108.bullet.mail.ne1.yahoo.com with NNFMP; 18 Mar 2015 15:59:39 -0000 Received: from [127.0.0.1] by smtp113.mail.ne1.yahoo.com with NNFMP; 18 Mar 2015 15:59:39 -0000 X-Yahoo-Newman-Id: 984224.81593.bm@smtp113.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: NNqKkvAVM1lXHeLOKPsDIesHI0zVwfiwNPIBsMkB0sb9f0H PRsxPtMmwUC.YBSClN2fre.pucVgfzTYyJvMX50FTE9ecVtP7n8bbgFDIyl7 3JePJhvn3Cr.UiGe0DzpgutBNtv5ZqPPfShWAAolzsK2AXh.mszioNk2M24t Rq.oNgunA3.m8owvbMjtl_EiKKMrzkuphYUdvDbpcdfWb2l_qqVjHH1dk6xN iSyCrf4fjXMNf656Oh1VEZ9E9rf4wsVc0ViJKOX9_E3kuHPEERqq7neIM0W2 hjfTSP0bDx69pxczbstfckUvfj2VGd1x5AXtQBMtymezHr6RWYqs2L4UkkPQ i1MtOun.RT7qzbIs4sN1gvlB__2VNa9g3fTdHdDQeND5nS1jqZbLkhp03B73 30Vy0ekqkojTSeYo1VnWlJYECQXZOR_roi97keFFGKLWTKFVj2yJ6MR84lcv 5klnzN_dq6Hggp6gnUQV5moPgOd3nGTKqr_kQZH4Dp2YV2.8yz9xlI4_5.Ng ugVLLI23r3i8n1nfOiQV_vTCqmNnQnzHcp0ioeGXd6Chjqlhn X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <5509A0EA.4070208@att.net> Date: Wed, 18 Mar 2015 11:59:38 -0400 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Warner Losh Subject: Re: [PATCH] ACPI CMOS region support rev. 5 References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: freebsd-acpi@freebsd.org, Ian Smith X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 15:59:47 -0000 On 03/18/2015 11:26 AM, Warner Losh wrote: > Looking at patch 5: > > You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI attachment in there. Okay, shouldn't be a problem. > You should also split off the little bit that’s ISA-specific into atrtc_isa. You mean rtcin() and writertc()? ...but that's not my stuff, it was already in atrtc.c. PNP0800 (the PC-AT RTC component) is (practically) an ISA-specific device. Anthony > Once you do that, we can talk. > > Warner >