From owner-freebsd-mobile Tue Jul 31 3:50:40 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from web11401.mail.yahoo.com (web11401.mail.yahoo.com [216.136.131.231]) by hub.freebsd.org (Postfix) with SMTP id AF82037B401 for ; Tue, 31 Jul 2001 03:50:37 -0700 (PDT) (envelope-from shizukakudo_99@yahoo.com) Message-ID: <20010731105037.47206.qmail@web11401.mail.yahoo.com> Received: from [202.167.61.228] by web11401.mail.yahoo.com; Tue, 31 Jul 2001 03:50:37 PDT Date: Tue, 31 Jul 2001 03:50:37 -0700 (PDT) From: Shizuka Kudo Subject: RE:Better patches To: Warner Losh , mobile@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Warner, Looking at your patch pcic-stable.diff.14a, Your pcic_pci_attach() has the following lines + sc->bst = sp->bst = rman_get_bustag(sc->memres); + sc->bst = sp->bsh = rman_get_bushandle(sc->memres); do you mean to have sc->bst assigned twice? or should the second line be sc->bsh = sp->bsh = .... __________________________________________________ Do You Yahoo!? Make international calls for as low as $.04/minute with Yahoo! Messenger http://phonecard.yahoo.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message