From owner-freebsd-ports Fri Jul 14 4:30:59 2000 Delivered-To: freebsd-ports@freebsd.org Received: from kbtfw.kubota.co.jp (kbtfw.kubota.co.jp [133.253.102.202]) by hub.freebsd.org (Postfix) with ESMTP id 1DC2A37C648; Fri, 14 Jul 2000 04:30:52 -0700 (PDT) (envelope-from haro@tk.kubota.co.jp) Received: by kbtfw.kubota.co.jp; id UAA25576; Fri, 14 Jul 2000 20:30:50 +0900 (JST) Received: from unknown(133.253.122.1) by kbtfw.kubota.co.jp via smap (V4.2) id xma025527; Fri, 14 Jul 00 20:30:26 +0900 Received: from jkpc15.tk.kubota.co.jp ([192.168.7.250]) by kbtmx.eto.kubota.co.jp (8.9.3+3.2W/3.7W) with ESMTP id UAA10428; Fri, 14 Jul 2000 20:30:25 +0900 (JST) Received: from localhost (localhost.ttr.kubota.co.jp [127.0.0.1]) by jkpc15.tk.kubota.co.jp (8.9.3/3.7W-02/21/99) with ESMTP id UAA01155; Fri, 14 Jul 2000 20:28:39 +0900 (JST) To: Archie Cobbs Cc: freebsd-current@freebsd.org, freebsd-ports@freebsd.org Subject: ether_ifattach() change and VMware X-Mailer: Mew version 1.94.1 on Emacs 20.6 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20000714202839P.haro@tk.kubota.co.jp> Date: Fri, 14 Jul 2000 20:28:39 +0900 From: haro@tk.kubota.co.jp (Munehiro Matsuda) X-Dispatcher: imput version 990905(IM130) Lines: 48 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Date: Thu, 13 Jul 2000 15:54:35 -0700 (PDT) From: Archie Cobbs :: ::archie 2000/07/13 15:54:35 PDT :: :: Modified files: :: Log: :: Make all Ethernet drivers attach using ether_ifattach() and detach using :: ether_ifdetach(). :: :: The former consolidates the operations of if_attach(), ng_ether_attach(), :: and bpfattach(). The latter consolidates the corresponding detach operations. :: :: Reviewed by: julian, freebsd-net Hello, After the commit, VMware seems to hang the system at boot time. The "vmnet" module, that comes with VMware, needs the included patch. Shouldn't we bump version or something, due to the kernel API change? ---8<------8<------8<-- patch for VMware --8<------8<------8<------8<--- --- vmnet-only/freebsd/vmnet.c.org Fri Jul 14 16:18:50 2000 +++ vmnet-only/freebsd/vmnet.c Fri Jul 14 16:21:51 2000 @@ -156,9 +156,7 @@ DLog(Linfo, DEVICE_NAME "%d: Ethernet address: %6D", ifp->if_unit, sc->iface.arpcom.ac_enaddr, ":"); s = splimp(); - if_attach(ifp); - ether_ifattach(ifp); - bpfattach(ifp, DLT_EN10MB, sizeof(struct ether_header)); + ether_ifattach(ifp, ETHER_BPF_SUPPORTED); splx(s); return 0; ---8<------8<------8<------8<------8<------8<------8<------8<------8<--- Thank you, Haro =------------------------------------------------------------------------------ _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| Business Incubation Dept., Kubota Corp. /|\ |_| |_|_| 1-3 Nihonbashi-Muromachi 3-Chome Chuo-ku Tokyo 103-8310, Japan Tel: +81-3-3245-3318 Fax: +81-3-3245-3315 Email: haro@kubota.co.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message