From nobody Sun Mar 3 09:01:41 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TnbS16g2Cz5CLlb; Sun, 3 Mar 2024 09:02:09 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TnbS151gLz4Vpw; Sun, 3 Mar 2024 09:02:09 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-7d2e19120b5so2096069241.2; Sun, 03 Mar 2024 01:02:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709456529; x=1710061329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R4M7Rq8VQeTw+9aDYQp6uFmqYb4GDMZP3KpgE/7KvOw=; b=i910AYNmgsoZszao/4HsWpmvIEyGSEnlk1kfmVxXXP8p4Ii27Qd4Cnpxzsqv2Iaoim 12sxhTcp4i+v+9s6LROp5C5TOx6ZZu5HY5UNazVgUzY8r76Yh/1n/MuKATHHV2TPt6vQ fgqILVnH8oS94iTTs+dQq0t2Fkdt2p+t1iFDdLUdAvcvnZZZJA0pSnJph4F6GtoIAZaz RY2YwkrPoBsMju/jaIDgk4PX4KBmBvALy1KLTKahsG9GHg5S/tjGyFzFhXUGbIAm/Uer OR0T+uplMEa1qCNUEOA2k7rFWw7gLzO9BdmgDIrZQ5n/yguSOrwSYL+TGt1xTK0inhvO yAcg== X-Forwarded-Encrypted: i=1; AJvYcCUrEi+PmY3HXFMhlHjnhfdBl7kos6aipAfjYPEJGC/YKWhpoevdW516tFt9yxRMhtc0LUM4Cr92SF/kIDp+PQnrhR5oDHyvfVhjDVmwcD2NC3OQgPAIxUBb6h6LSLjm6zQQcwW60biKO5bOaVJD1tao9RKkFJoUw7PSkDoS9rKl+wUE1evHPPT5+LzTbeb3j1uwUrA= X-Gm-Message-State: AOJu0Yzbx8YZW5qx9gvZLmeWMmeW9fbnOXkTxpXDaYlyJLCbq/XwfQRW ewZ+q0oM0IjRjwRNeJC7SBxGA10o/RXQnjXLkY3gzbnrkdfUwSbj1khWqH4//88= X-Google-Smtp-Source: AGHT+IFniG24faijptEzzLKaXSMW0GBlvWYiJyxkIf4LMtwzyEwMMtVfiVEQcNe2jVYurhdjJ+LYzw== X-Received: by 2002:a05:6122:a26:b0:4d3:3446:6bcb with SMTP id 38-20020a0561220a2600b004d334466bcbmr4338566vkn.16.1709456528664; Sun, 03 Mar 2024 01:02:08 -0800 (PST) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com. [209.85.222.42]) by smtp.gmail.com with ESMTPSA id l10-20020ac5c34a000000b004c003cf5e14sm843338vkk.28.2024.03.03.01.02.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Mar 2024 01:02:08 -0800 (PST) Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-7d995bd557eso2208959241.0; Sun, 03 Mar 2024 01:02:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV5hgQJprH7qW2VERIkyEgtKGd0DAtg5GTUv+b3yOfR8GvEA6a3fRBDrYQJxt0gZes45O0zAURS92wRX+n6jffaCVKUGhWN4gFoIaeyt44z/SCpUL8onS5GTa06LT993x7N6ZqMlz0w2NSMaiQJzpIxXqHS821W0GVRUqrXN3DVDBL4NWxBeGFRzYlQqlfxlKJ9qXs= X-Received: by 2002:a05:6102:559c:b0:472:a0f3:9c5f with SMTP id dc28-20020a056102559c00b00472a0f39c5fmr4887600vsb.23.1709456528290; Sun, 03 Mar 2024 01:02:08 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> In-Reply-To: <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> From: Gleb Popov Date: Sun, 3 Mar 2024 12:01:41 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG To: Mathieu Arnold Cc: Thomas Zander , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4TnbS151gLz4Vpw On Sun, Mar 3, 2024 at 11:56=E2=80=AFAM Mathieu Arnold wr= ote: > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > knob, and not via an option. > If there is an option that enable some sort of debugging or verbose > thing but that is not supposed to add debugging symbols, then it should > not be called DEBUG. In that case we need a qa check that prevents adding DEBUG option and then we can also introduce a generic DEBUG_VAR helper to get rid of ifdefs?