From owner-freebsd-audit Mon Jul 2 20:49:22 2001 Delivered-To: freebsd-audit@freebsd.org Received: from iatl0x01.coxmail.com (iatl1x01.coxmail.com [206.157.231.23]) by hub.freebsd.org (Postfix) with ESMTP id A3C5737B401 for ; Mon, 2 Jul 2001 20:49:18 -0700 (PDT) (envelope-from mheffner@novacoxmail.com) Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178]) by iatl0x01.coxmail.com (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2) with ESMTP id <20010703034917.RLVZ1034.iatl0x01@enterprise.muriel.penguinpowered.com>; Mon, 2 Jul 2001 23:49:17 -0400 Message-ID: X-Mailer: XFMail 1.5.0 on FreeBSD X-Priority: 3 (Normal) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="_=XFMail.1.5.0.FreeBSD:20010702234816:393=_"; micalg=pgp-md5; protocol="application/pgp-signature" In-Reply-To: Date: Mon, 02 Jul 2001 23:48:16 -0400 (EDT) Reply-To: Mike Heffner From: Mike Heffner To: Mike Heffner Subject: RE: src/bin/chio patch Cc: audit@FreeBSD.org, Mike Barcroft Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format --_=XFMail.1.5.0.FreeBSD:20010702234816:393=_ Content-Type: text/plain; charset=us-ascii On 03-Jul-2001 Mike Heffner wrote: | | On 29-Jun-2001 Mike Barcroft wrote: || I would appreciate it if someone would review and commit the patch at || the end of this message. Also available at: || http://testbed.q9media.net/freebsd/chio.20010628.patch || | | Done, thanks! Unfortunately I had to revert the Makefile WARNS addition because I forgot to test on alpha first ;( I'll try and look at cleaning up the alpha warnings tomorrow. Below is the compiler warnings from beast in case anyone wants to take a stab at it: cc -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align -Wcast-qual -Wchar-subscr ipts -Wconversion -Winline -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wre dundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings -c chio.c chio.c:124: warning: function declaration isn't a prototype chio.c: In function `do_status': chio.c:692: warning: passing arg 1 of `calloc' with different width due to prototype chio.c:711: warning: passing arg 1 of `bits_to_string' as signed due to prototype chio.c: In function `do_voltag': chio.c:849: warning: pointer targets in passing arg 1 of `strncpy' differ in signedness chio.c: In function `do_return': chio.c:1009: warning: passing arg 1 of `get_element_status' with different width due to prototype chio.c:1009: warning: passing arg 2 of `get_element_status' with different width due to prototype chio.c: In function `get_element_status': chio.c:1047: warning: promoted argument `type' doesn't match prototype chio.c:69: warning: prototype declaration chio.c:1047: warning: promoted argument `element' doesn't match prototype chio.c:69: warning: prototype declaration chio.c:1052: warning: passing arg 1 of `calloc' with different width due to prototype chio.c: In function `find_element': chio.c:1105: warning: passing arg 1 of `calloc' with different width due to prototype chio.c:1188: warning: pointer targets in passing arg 2 of `strcasecmp' differ in signed ness Mike -- Mike Heffner Fredericksburg, VA --_=XFMail.1.5.0.FreeBSD:20010702234816:393=_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7QUCAFokZQs3sv5kRAl60AJ9Jo2xegNnPKlLBpgZcq66DbzVkQQCeLgFO kdjNU7+MQLeVN+POvxAIa6E= =WvN3 -----END PGP SIGNATURE----- --_=XFMail.1.5.0.FreeBSD:20010702234816:393=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message