Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Oct 2016 08:39:34 +0000 (UTC)
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r307958 - stable/11/usr.bin/printenv
Message-ID:  <201610260839.u9Q8dYSM029072@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gahr (ports committer)
Date: Wed Oct 26 08:39:33 2016
New Revision: 307958
URL: https://svnweb.freebsd.org/changeset/base/307958

Log:
  MFC r307638:
  
  Chase a cornercase in printenv and sync its behaviour with builtin's
  
  The cornercase is when printenv is passed a parameter in the form
  VAR=val, where VAR=val exists in the environment. In this case, printenv would
  print a spurious newline and returns 0.
  
  Approved by:	cognet
  MFC after:		1 week

Modified:
  stable/11/usr.bin/printenv/printenv.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/usr.bin/printenv/printenv.c
==============================================================================
--- stable/11/usr.bin/printenv/printenv.c	Wed Oct 26 07:45:48 2016	(r307957)
+++ stable/11/usr.bin/printenv/printenv.c	Wed Oct 26 08:39:33 2016	(r307958)
@@ -83,8 +83,8 @@ main(int argc, char *argv[])
 	for (ep = environ; *ep; ep++)
 		if (!memcmp(*ep, *argv, len)) {
 			cp = *ep + len;
-			if (!*cp || *cp == '=') {
-				(void)printf("%s\n", *cp ? cp + 1 : cp);
+			if (*cp == '=') {
+				(void)printf("%s\n", cp + 1);
 				exit(0);
 			}
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201610260839.u9Q8dYSM029072>