From owner-freebsd-ppc@FreeBSD.ORG  Fri Jun  1 02:28:18 2012
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
Delivered-To: powerpc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 913AE106564A;
	Fri,  1 Jun 2012 02:28:18 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 568B38FC15;
	Fri,  1 Jun 2012 02:28:18 +0000 (UTC)
Received: from marcelm-sslvpn-nc.jnpr.net (natint3.juniper.net [66.129.224.36])
	(authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q512S3SV054016
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Thu, 31 May 2012 19:28:11 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <fcdca283083e354eb4d9733a572a1041@smtp.semihalf.com>
Date: Thu, 31 May 2012 19:27:58 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <FF83351D-A575-4388-9113-2BCF280ECADE@xcllnt.net>
References: <0362C399-CB54-451E-A879-E836EF13CE72@semihalf.com>
	<251AF144-587C-4854-88B2-0CD7D26E1DF1@xcllnt.net>
	<fcdca283083e354eb4d9733a572a1041@smtp.semihalf.com>
To: Zbigniew Bodek <zbb@semihalf.com>
X-Mailer: Apple Mail (2.1278)
Cc: powerpc@freebsd.org, =?utf-8?Q?Piotr_Zi=C4=99cik?= <kosmo@semihalf.com>
Subject: Re: RFC: OpenPIC IPI patch
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2012 02:28:18 -0000


On May 31, 2012, at 4:07 PM, Zbigniew Bodek wrote:

> @@ -344,8 +345,14 @@ void
> openpic_ipi(device_t dev, cpuset_t cpumask)
> {
> 	struct openpic_softc *sc;
> +	cpuset_t ns_cpus;	/* Mask of not supported CPUs */
> +
> +	CPU_FILL(&ns_cpus);
> +	ns_cpus.__bits[0] = 0;
> 
> 	KASSERT(dev == root_pic, ("Cannot send IPIs from non-root OpenPIC"));
> +	KASSERT(CPU_OVERLAP(&ns_cpus,  &cpumask) == 0,
> +	    ("Cannot send an IPI to a CPU which number exceeds #31"));
> 
> 	sc = device_get_softc(dev);
> 	sched_pin();
> 

I like it.
Thanks,

-- 
Marcel Moolenaar
marcel@xcllnt.net