From owner-freebsd-current  Mon Feb 12  2:54:13 2001
Delivered-To: freebsd-current@freebsd.org
Received: from fjord.dignus.com (sdsl-64-244-29-38.dsl.rdu.megapath.net [64.244.29.38])
	by hub.freebsd.org (Postfix) with ESMTP id 12F0E37B491
	for <current@FreeBSD.ORG>; Mon, 12 Feb 2001 02:54:06 -0800 (PST)
Received: from lakes.dignus.com (lakes.dignus.com [10.0.0.3])
	by fjord.dignus.com (8.11.1/8.11.1) with ESMTP id f1CAsPn89354;
	Mon, 12 Feb 2001 05:54:25 -0500 (EST)
	(envelope-from rivers@dignus.com)
Received: (from rivers@localhost) by lakes.dignus.com (8.9.3/8.6.9) id FAA04990; Mon, 12 Feb 2001 05:53:59 -0500 (EST)
Date: Mon, 12 Feb 2001 05:53:59 -0500 (EST)
From: Thomas David Rivers <rivers@dignus.com>
Message-Id: <200102121053.FAA04990@lakes.dignus.com>
To: eischen@vigrid.com, peter@netplex.com.au
Subject: Re: HEADS UP: installworld gotchas
Cc: bde@zeta.org.au, current@FreeBSD.ORG, dillon@earth.backplane.com,
	Tor.Egge@fast.no
In-Reply-To: <Pine.SUN.3.91.1010211210356.26151B-100000@pcnet1.pcnet.com>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


On Sun, 11 Feb 2001, Peter Wemm wrote:
> Matt Dillon wrote:
> > 
> > :   
> > :   This is a major change to libc.  The library maj must be bumped if you
> > :   intend to change the sizeof(FILE), or every single third party applicatio
>     n
> > :   that uses stdio will break.
> > :
> > :				-Matt
> > 
> >     Oh wait, is libc already bumped in current verses 4.2?  If so then I gues
>     s
> >     we don't bump libc's maj.  God help anyone using current though!
> > 
> > 					-Matt
> 
> 
> I cant help but wonder why on earth we didn't have it like this from the
> start:
[...]
> That compiles fine. The __stdin thing is in case somebody likes the idea
> of #undef stdin or #ifdef stdin for some reason.
> 
> In fact, I can't imagine *any* reason not to do this. At least this would
> insulate us from future nasties in FILE size changes, and would have
> saved us in this case.

Wouldn't this change/break code like the following?

main()
{
   FILE **fp;

   fp = &stdin;

   my_func(fp);
}

That is, previously &stdin would work...   in this new situation,
you would get &__stdin which is not the same... is it?


	- Dave Rivers -





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message