From owner-svn-src-head@FreeBSD.ORG  Sat May 14 01:10:58 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2EC58106566C;
	Sat, 14 May 2011 01:10:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E85F8FC08;
	Sat, 14 May 2011 01:10:58 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p4E1AwcK088068;
	Sat, 14 May 2011 01:10:58 GMT (envelope-from jhb@svn.freebsd.org)
Received: (from jhb@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id p4E1Awgm088066;
	Sat, 14 May 2011 01:10:58 GMT (envelope-from jhb@svn.freebsd.org)
Message-Id: <201105140110.p4E1Awgm088066@svn.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Sat, 14 May 2011 01:10:57 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r221867 - head/sys/fs/ext2fs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 May 2011 01:10:58 -0000

Author: jhb
Date: Sat May 14 01:10:57 2011
New Revision: 221867
URL: http://svn.freebsd.org/changeset/base/221867

Log:
  Merge comments about converting directory entries to be more direct and
  concise.
  
  Inspired by:	Gleb Kurtsou

Modified:
  head/sys/fs/ext2fs/ext2_lookup.c

Modified: head/sys/fs/ext2fs/ext2_lookup.c
==============================================================================
--- head/sys/fs/ext2fs/ext2_lookup.c	Sat May 14 00:45:35 2011	(r221866)
+++ head/sys/fs/ext2fs/ext2_lookup.c	Sat May 14 01:10:57 2011	(r221867)
@@ -119,17 +119,11 @@ static int	ext2_dirbadentry(struct vnode
 /*
  * Vnode op for reading directories.
  *
- * The routine below assumes that the on-disk format of a directory
- * is the same as that defined by <sys/dirent.h>. If the on-disk
- * format changes, then it will be necessary to do a conversion
- * from the on-disk format that read returns to the format defined
- * by <sys/dirent.h>.
- */
-/*
- * this is exactly what we do here - the problem is that the conversion
- * will blow up some entries by four bytes, so it can't be done in place.
- * This is too bad. Right now the conversion is done entry by entry, the
- * converted entry is sent via uiomove.
+ * This function has to convert directory entries from the on-disk
+ * format to the format defined by <sys/dirent.h>.  Unfortunately, the
+ * conversion will blow up some entries by four bytes, so it can't be
+ * done in place.  Instead, the conversion is done entry by entry and
+ * the converted entry is sent via uiomove.
  *
  * XXX allocate a buffer, convert as many entries as possible, then send
  * the whole buffer to uiomove