Date: Sun, 13 Aug 2000 15:55:41 -0500 From: Steve Price <sprice@hiwaay.net> To: Satoshi - Ports Wraith - Asami <asami@freebsd.org> Cc: alex@freebsd.org, ports@freebsd.org Subject: Re: cvs commit: ports/games/xsok Makefile Message-ID: <20000813155541.Y90230@bonsai.hiwaay.net> In-Reply-To: <vqcya213r1k.fsf@silvia.hip.berkeley.edu>; from asami@freebsd.org on Sun, Aug 13, 2000 at 12:21:59PM -0700 References: <200008131635.JAA13051@freefall.freebsd.org> <20000813183919.B20187@cichlids.cichlids.com> <20000813114249.S90230@bonsai.hiwaay.net> <20000813185728.A23014@cichlids.cichlids.com> <20000813121453.U90230@bonsai.hiwaay.net> <20000813122802.W90230@bonsai.hiwaay.net> <vqcya213r1k.fsf@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 13, 2000 at 12:21:59PM -0700, Satoshi - Ports Wraith - Asami wrote:
# IMO, the USE_IMAKE directive should imply that the port requires
# imake, not that it runs xmkmf. The latter should have been called
# USE_XMKMF or something, so they will work like this.
#
# USE_IMAKE: dependency on devel/imake-4 and X libraries
# USE_XMKMF: implies USE_IMAKE, runs xmkmf
I like this idea but wouldn't it violate POLA. Every port that uses
USE_IMAKE today would be changed to USE_XMKMF.
#
# But this might be another change that is too drastic. ;)
#
# Another way around the problem would be to add an easy way to disable
# running xmkmf when USE_IMAKE is defined. (Did I hear someone say
# "XMKMF=/usr/bin/true" ? ;)
This would work. Maybe we need a knob named NEED_IMAKE where
NEED_IMAKE: dependency on devel/imake-4 and X libraries
USE_IMAKE: implies NEED_IMAKE, run xmkmf
All of the USE_* variables we have today either link against or run the
bits that are being used. In this case (e.g. games/xsok) we just need the
bits around and the port uses them itself. Wait that doesn't make much
sense does it? :)
I think the solution you describe above is the cleanest way, but it may
lead to confusion for people that update ports piecemeal without updating
the Mk files too. If you do it let's make sure BSDPORTMKVERSION gets
bumped.
-steve
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000813155541.Y90230>