From owner-svn-ports-head@freebsd.org  Tue Nov 24 11:01:52 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD9F3A368B5;
 Tue, 24 Nov 2015 11:01:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id B72331F9D;
 Tue, 24 Nov 2015 11:01:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 7583B19F6; Tue, 24 Nov 2015 11:01:52 +0000 (UTC)
Date: Tue, 24 Nov 2015 11:01:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Gerald Pfeifer <gerald@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r402352 - head/lang/gcc
Message-ID: <20151124110152.GA78748@FreeBSD.org>
References: <201511241019.tAOAJMTF049917@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201511241019.tAOAJMTF049917@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 11:01:52 -0000

On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote:
> Author: gerald
> URL: https://svnweb.freebsd.org/changeset/ports/402352
> 
> [...]
> @@ -168,5 +168,10 @@ post-stage:
>  	fi
>  .endfor
>  	cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST}
> +	# This is the canonical GCC port, so add key commands without
> +	# version numbers as part of their names.

Comment is badly indented (will be executed as part of the target recipe).

> +	for c in gfortran g++ gcc; do \
> +	    ${LN} -s ${PREFIX}/bin/"$$c"${SUFFIX} ${STAGEDIR}${PREFIX}/bin/$$c ; \
> +	done

Symlinks are badly created (will be broken if e.g. $prefix mounted under
non-/ via NFS), better (untested) approach would be:

.for f in gfortran g++ gcc
	${LN} -sf ${f}${SUFFIX} ${STAGEDIR}${PREFIX}/bin/${f}
.endfor

./danfe