From owner-cvs-sys Thu Mar 30 23:54:04 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA23831 for cvs-sys-outgoing; Thu, 30 Mar 1995 23:54:04 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA23813; Thu, 30 Mar 1995 23:54:00 -0800 Received: from estienne.cs.berkeley.edu (estienne.CS.Berkeley.EDU [128.32.42.147]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id XAA03316; Thu, 30 Mar 1995 23:53:57 -0800 Received: from localhost (localhost [127.0.0.1]) by estienne.cs.berkeley.edu (8.6.9/8.6.9) with SMTP id XAA01697; Thu, 30 Mar 1995 23:53:46 -0800 Message-Id: <199503310753.XAA01697@estienne.cs.berkeley.edu> X-Authentication-Warning: estienne.cs.berkeley.edu: Host localhost didn't use HELO protocol To: Gennady Sorokopud cc: "Jordan K. Hubbard" , CVS-commiters@time.cdrom.com, cvs-sys@time.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa if_ep.c if_epreg.h In-reply-to: Your message of "Fri, 31 Mar 1995 10:44:06 +0300." <199503310744.KAA09715@Burka.NetVision.net.il> Date: Thu, 30 Mar 1995 23:53:46 -0800 From: "Justin T. Gibbs" Sender: cvs-sys-owner@freebsd.org Precedence: bulk >>>jkh 95/03/30 22:41:39 >>> >>> Modified: sys/i386/isa if_ep.c if_epreg.h >>> Log: >>> * Promiscuous mode added and interrupt logic slightly changed >>> * to reduce the number of adapter failures. Transceiver select >>> * logic changed to use value from EEPROM. Autoconfiguration >>> * features added. >>> Submitted by: "Serge A. Babkin" >> >>Did you test these on a 3c509? I was planning on testing these patches >>tomorrow (my office machine has a 3C509) and then committing. When >>david commited the last batch of patches from Serge, it was only after >>I tested them out first. >>-- >>Justin T. Gibbs >>============================================== >>TCS Instructional Group - Programmer/Analyst 1 >> Cory | Po | Danube | Volga | Parker | Torus >>============================================== >I've tested it . (I have 2 FreeBSD-current machines with 3c509 cards here ). >Works fine , even the promiscous mode! I finally can get rid of >old NE1000 that i used as spying agent :)) > Oh, I'm not saying that they won't work, but in most cases, if there is someone on the commit list that has the specific hardware to test a patch, it will be tested before being comitted. The reason that only certain people have commit priveledges is so that patches can be reviewed before being incorperated into the tree. My question to Jordan was about how good a review he gave the code before putting it in the tree. > >O Gennady Sorokopud O -- Justin T. Gibbs ============================================== TCS Instructional Group - Programmer/Analyst 1 Cory | Po | Danube | Volga | Parker | Torus ==============================================