From owner-freebsd-ports Sat Mar 15 10:17: 6 2003 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DF6737B401; Sat, 15 Mar 2003 10:17:03 -0800 (PST) Received: from creme-brulee.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id B126B43F75; Sat, 15 Mar 2003 10:17:01 -0800 (PST) (envelope-from marcus@marcuscom.com) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.12.8/8.12.8) with ESMTP id h2FIG6rI059891; Sat, 15 Mar 2003 13:16:07 -0500 (EST) (envelope-from marcus@marcuscom.com) Subject: Re: Fail to build XEmacs with GTK From: Joe Marcus Clarke To: Alexander Leidinger Cc: DougB@FreeBSD.ORG, ports@FreeBSD.ORG In-Reply-To: <20030315143137.57769881.Alexander@Leidinger.net> References: <1047615404.66262.7.camel@shumai.marcuscom.com> <20030314043154.GA94526@rot13.obsecurity.org> <1047616453.66262.10.camel@shumai.marcuscom.com> <20030313230858.H1839@znfgre.tberna.bet> <1047645619.2553.4.camel@shumai.marcuscom.com> <20030314210940.N1839@znfgre.tberna.bet> <1047709502.75367.3.camel@shumai.marcuscom.com> <20030315143137.57769881.Alexander@Leidinger.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WG4BSHfH+zv4K0BG2h20" Organization: MarcusCom, Inc. Message-Id: <1047752213.81982.10.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 15 Mar 2003 13:16:54 -0500 X-Spam-Status: No, hits=-39.4 required=5.0 tests=BAYES_01,EMAIL_ATTRIBUTION,IN_REP_TO,PGP_SIGNATURE_2, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --=-WG4BSHfH+zv4K0BG2h20 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2003-03-15 at 08:31, Alexander Leidinger wrote: > On 15 Mar 2003 01:25:02 -0500 > Joe Marcus Clarke wrote: >=20 > > > > (And, for backwards compatibility's sake, WITH_GTK will still be ar= ound > > > > for a while). > > >=20 > > > IMO, it should stay around in perpetuity. > >=20 > > For the reasons I listed above, I don't think this is a good idea. Why > > is it such a problem to substitute WITH_GTK with USE_GNOME=3Dgtk12? Af= ter > > all, this is documented. Sorry, I was tired last night. This should have said: USE_GTK vs. USE_GNOME=3Dgtk12 >=20 > I think Doug is concerned about how this looks to people which aren't > that familiar with the ports tree. >=20 > It's ok for port maintainers/committers, but for an 'ordinary' user it > may sound as it needs/depends on GNOME. And if such an user doesn't want > GNOME to get installed, he may decide to not install such a port without > trying if it actually installs GNOME or not. The port author is still the one in control, and is free to use WITH_GTK as a knob if they desire. However, they have to translate that in their port to be USE_GNOME=3Dgtk12 instead of USE_GTK. Therefore, they can still do something like this: pre-configure:: @${ECHO_MSG} "" @${ECHO_MSG} "This sport has the following option(s):" @${ECHO_MSG} "" @${ECHO_MSG} "WITH_GTK=3Dyes Enable GTK+-1.2 support" @${ECHO_MSG} "" Then they can add something like this: .if defined(WITH_GTK) USE_GNOME=3D gtk12 .endif However, they are free to also use the built-in WANT_GNOME/HAVE_GNOME method with handles autodetection as well: WANT_GNOME=3D yes ... .if ${HAVE_GNOME:Mgtk12}!=3D"" USE_GNOME=3D gtk12 .endif And even combine them if they like: WANT_GNOME=3D yes ... .if ${HAVE_GNOME:Mgtk12}!=3D"" || defined(WITH_GTK) USE_GNOME=3D gtk12 .endif All of this can be made transparent to the end user. It's just that in GNOMENG (soon to be just regular GNOME), the WITH_GTK macro is no longer magical. It's no longer reserved. The porter is still free to use it, though. Hope this helps clear things up a bit. Joe >=20 > Bye, > Alexander. --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-WG4BSHfH+zv4K0BG2h20 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+c24Vb2iPiv4Uz4cRAqOSAJ4yG4AnYfzaltvtIPG+D1mAc7Yg6wCdErLv ca286K79GeMniDAziQfMZdQ= =iq8u -----END PGP SIGNATURE----- --=-WG4BSHfH+zv4K0BG2h20-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message