From owner-cvs-all Tue Nov 19 18:19: 0 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB60137B401 for ; Tue, 19 Nov 2002 18:18:58 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id CB4C343E97 for ; Tue, 19 Nov 2002 18:18:57 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 62021 invoked by uid 1000); 20 Nov 2002 02:18:59 -0000 Date: Tue, 19 Nov 2002 18:18:59 -0800 (PST) From: Nate Lawson To: Kris Kennaway Cc: Nate Lawson , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_cd.h src/sys/dev/ata atapi-cd.c src/sys/sys cdrio.h src/usr.sbin/burncd burncd.8 burncd.c src/usr.sbin/cdcontrol cdcontrol.1 cdcontrol.c In-Reply-To: <20021119165032.A26021@citusc.usc.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 19 Nov 2002, Kris Kennaway wrote: > On Tue, Nov 19, 2002 at 04:26:19PM -0800, Nate Lawson wrote: > > njl 2002/11/19 16:26:19 PST > > > > Modified files: (Branch: RELENG_4) > > sys/cam/scsi scsi_cd.c scsi_cd.h > > sys/dev/ata atapi-cd.c > > sys/sys cdrio.h > > usr.sbin/burncd burncd.8 burncd.c > > usr.sbin/cdcontrol cdcontrol.1 cdcontrol.c > > Log: > > MFC: > > * Add CDRIOC{READ,WRITE}SPEED ioctls to cd(4). Units are in KB/sec. > > * Change atapi-cd ioctls to use the same units. > > * Change burncd, cdcontrol to convert CDROM speed to KB/sec before > > calling the ioctl. Add a "max" speed option for their command lines. > > Am I misunderstanding something, or will this change cause existing > applications to misbehave? See the HEADSUP on stable@ and ports@. Only people who were using the FreeBSD-only ioctls need to change, simply by multiplying by 177 (the kernel was doing this conversion before). API is preserved although units have changed. In practice, I know of no applications (cdrecord, dagrab, tosha) written to the FreeBSD cdrio.h ioctls. However I can't check every port, hence the message. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message