From owner-svn-ports-all@freebsd.org Tue Sep 8 02:03:59 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4D679CC72F; Tue, 8 Sep 2015 02:03:59 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A37B11ED5; Tue, 8 Sep 2015 02:03:59 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by padhk3 with SMTP id hk3so24461825pad.3; Mon, 07 Sep 2015 19:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=n7ZpPLLcJhyWmqJ8V8LlwgN6sGLOzy44b/62HpWmS8w=; b=utcWB4ETYQmn45topO2IEPavxQ5ch6ifonCa7vQVZicSVOuz8pS3/rOW5NdsP8M1Ob z+8IX6LDKcLZZZF/zFesUliqK35vbJOcto88wgkvBu3Rrb8Vt46oQJbr92OMjKE3N1wA fkeos6N8IcWd22xGNiF1SvGOC5Vhfqhn0u7TbCXoJth67pten06T/V5Rnhfpe53akg1x 0mMa9JmBEgEVm4vaHcS3PjjK1Bks4lAJ+D8WEqmkaeeSusmPGhbIvlHHs+5FUGADNoxr KJxAJwPwJP9pwgmNOaWmzAXPdTpKadNZONQem7Azvmh2yy9Azv8PrNR0KpVsO5C7eJLZ zyNw== X-Received: by 10.68.135.66 with SMTP id pq2mr52397701pbb.29.1441677839177; Mon, 07 Sep 2015 19:03:59 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01::4? (2001-44b8-31ae-7b01-0000-0000-0000-0004.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01::4]) by smtp.gmail.com with ESMTPSA id a1sm1210616pdp.61.2015.09.07.19.03.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Sep 2015 19:03:58 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r396248 - head/games/scummvm References: <201509070625.t876PBJV079503@repo.freebsd.org> <663DB8E120502884DE748209@atuin.in.mat.cc> <20150907070846.GA23292@FreeBSD.org> <55EE412F.4080802@FreeBSD.org> To: Alexey Dokuchaev , Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kubilay Kocak Message-ID: <55EE4208.3020405@FreeBSD.org> Date: Tue, 8 Sep 2015 12:03:52 +1000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Thunderbird/40.0 MIME-Version: 1.0 In-Reply-To: <55EE412F.4080802@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2015 02:03:59 -0000 On 8/09/2015 12:00 PM, Kubilay Kocak wrote: > On 7/09/2015 5:08 PM, Alexey Dokuchaev wrote: >> On Mon, Sep 07, 2015 at 08:46:51AM +0200, Mathieu Arnold wrote: >>> +--On 7 septembre 2015 06:25:11 +0000 Alexey Dokuchaev >>> wrote: >>> | New Revision: 396248 >>> | URL: https://svnweb.freebsd.org/changeset/ports/396248 >>> | >>> | Log: >>> | - Ensure that build logs in bulk (package) mode are useful by passing >>> | the --enable-verbose-build argument to configure script >>> >>> Why not always make the logs useful ? If I go and run make, I'll have some >>> output that's useless for me to debug, right ? >> >> Typically yes, I agree; I also prefer to always have full logs. However, >> a lot of people prefer to see them when needed, not always; this perception >> could be popularized by Linux kernel build being quite by default, OpeWRT, >> etc. Our own Uses/cmake.mk defines CMAKE_VERBOSE for patch/package builds >> only. On the other hand, with pkg(8) and binary packages becoming widely >> adopted, perhaps we can assume that building from the ports is expert mode >> and thus --enable-verbose-build/CMAKE_VERBOSE=yes/etc. should be rightful >> default. >> >> I was trying to preserve existing defaults, yet not pessimize cluster logs >> usefullness. I think if we could have consensus among ports folks that we >> always prefer verbose logs, I'm all for removing the checks and just always >> pass it. In fact, this will make quite a few ports less cluttered. >> >> ./danfe >> > > That (preserving/respecting current defaults) is the right thing to do. > > I advocate verbose by default across the board in the ports I maintain > already. Our defaults should be conducive to debug-ability, particularly > for the case of users providing feedback for maintainers. > > How about we exp-run for GNU_CONFIGURE=yes ports: > > CONFIGURE_ARGS+= --disable-silent-rules > MAKE_ENV+= V=1 (maybe even MAKE_ARGS) > > OR: > > Templates/config.site = enable_silent_rules=no, and > MAKE_ENV+= V=1 (maybe even MAKE_ARGS) > > AND maybe even: > > Quoting from: > https://www.gnu.org/software/automake/manual/html_node/Automake-Silent-Rules.html > > "Still, notwithstanding the rationales above, a developer who really > wants to make silent rules enabled by default in his own package can do > so by calling AM_SILENT_RULES([yes]) in configure.ac. " > > Could we also REINPLACE_CMD that? > > Quoting relevant snippets from above link: > > Passing --enable-silent-rules to configure will cause build rules to be > less verbose; the option --disable-silent-rules will cause normal > verbose output." > > At make run time, the default chosen at configure time may be > overridden: make V=1 will produce verbose output, make V=0 less verbose > output. > > Also, in projects using libtool, the use of silent rules can > automatically enable the libtool’s --silent option > There's also no reason we couldn't wrap what we do in a user option/knob, so that builds could be made verbose/silent in particular cases, or at the users command. ./koobs