Date: Thu, 1 Jun 2000 23:40:06 -0700 (PDT) From: Tim Vanderhoek <vanderh@ecf.utoronto.ca> To: freebsd-ports@FreeBSD.org Subject: Re: ports/18960: Add USE_APACHE ito bsd.port.mk for Apache module ports Message-ID: <200006020640.XAA07513@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/18960; it has been noted by GNATS.
From: Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To: hetzels@westbend.net
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/18960: Add USE_APACHE ito bsd.port.mk for Apache module ports
Date: Fri, 2 Jun 2000 02:31:10 -0400
On Thu, Jun 01, 2000 at 08:48:11PM -0500, hetzels@westbend.net wrote:
>
> +AP_TARGET!= ${APXS} -q TARGET
> +AP_SBINDIR!= ${APXS} -q SBINDIR
> +AP_INCLUDE!= ${APXS} -q INCLUDEDIR
> +AP_LIBEXEC!= ${APXS} -q LIBEXECDIR
> +AP_SYSCONF!= ${APXS} -q SYSCONFDIR
> +AP_PREFIX!= ${APXS} -q PREFIX
All of these should probably also be added to the list of precious
make vars preserved through the environment at the end of bsd.port.mk.
It would be faster to do something like:
_AP_PATHS!= ${APXS} -q TARGET SBINDIR INCLUDEDIR ... | \
${AWK} '{print "TARGET:" $1 " " "SBINDIR:" $2 ...}'
AP_TARGET=${_AP_PATHS:MTARGET*:S/^TARGET//}
AP_SBINDIR=${_AP_PATHS:MSBINDIR*:S/^SBINDIR//}
...
Then only _AP_PATHS would be worthwhile for listing as a previous make
variable.
For more trickery, you could get away with something like
AP_TARGET= `${APXS} -q TARGET`
for most cases, I imagine. That's fastest of all.
There's also no particular reason why ports that need these vars can't
simply set the vars themselves.
> + AP_LIBEXEC=${AP_LIBEXEC:S/^${PREFIX}\///} \
> + AP_SYSCONF=${AP_SYSCONF:S/^${PREFIX}\///}
> .endif
It also looks like there's an .endif missing, but I'm probably just
not reading the patch right. :)
--
Signature withheld by request of author.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006020640.XAA07513>