Date: Fri, 10 Feb 2012 20:42:37 +0100 From: Robert Millan <rmh@freebsd.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Subject: Re: svn commit: r230972 - in head: share/mk sys/amd64/conf sys/i386/conf sys/modules sys/modules/drm sys/modules/sound/driver sys/modules/usb tools/build/options Message-ID: <CAOfDtXPxaMGvsfkVDcURbs9GF_TLMLJSgiFr%2BERYj11T1fdrfA@mail.gmail.com> In-Reply-To: <DF30EB99-B56C-43B8-B149-EE42A610BBFC@lists.zabbadoz.net> References: <201202040054.q140siBP012241@svn.freebsd.org> <4F2CFEE3.6070306@daemonic.se> <DF30EB99-B56C-43B8-B149-EE42A610BBFC@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--90e6ba6e81ccc1113d04b8a15409 Content-Type: text/plain; charset=UTF-8 Hi all, Sorry for the late reply. I can't keep up with mail during the week. 2012/2/4, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net>: > And can you please include GENERIC at least in these kernel configs? They > are not building and this breaks a make universe and I guess eventually the > tinderbox as well... Including GENERIC sounds problematic because if both WITHOUT_* files are included, then GENERIC is included twice! As discussed on -arch, the idea was that users would never build WITHOUT_* directly, but rather include them in their custom kernel config. These files weren't intended to be picked up by "make universe" either [1]. It just didn't occur to me that the universe target would pick them up. Here's a possible solution to this patch (untested). In case it looks fine to everyone (and my mentors approve it), I'll definitely test with "make universe" before commit. [1] shame on me for not testing lasest version of my patch with "make universe" -- I only tested the first one which didn't add WITHOUT_* files. -- Robert Millan --90e6ba6e81ccc1113d04b8a15409 Content-Type: text/plain; charset=US-ASCII; name="exclude_without_files.diff" Content-Disposition: attachment; filename="exclude_without_files.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAyMzA5NzEp CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtNDA0LDcgKzQwNCw3IEBACiAuZW5kaWYK IEtFUk5DT05GUyE9CWNkICR7S0VSTlNSQ0RJUn0vJHtUQVJHRVR9L2NvbmYgJiYgXAogCQlmaW5k IFtBLVowLTldKltBLVowLTldIC10eXBlIGYgLW1heGRlcHRoIDAgXAotCQkhIC1uYW1lIERFRkFV TFRTICEgLW5hbWUgTk9URVMKKwkJISAtbmFtZSBERUZBVUxUUyAhIC1uYW1lIE5PVEVTICEgLW5h bWUgV0lUSE9VVF9cKgogdW5pdmVyc2Vfa2VybmNvbmZzOgogLmZvciBrZXJuZWwgaW4gJHtLRVJO Q09ORlN9CiBUQVJHRVRfQVJDSF8ke2tlcm5lbH0hPQljZCAke0tFUk5TUkNESVJ9LyR7VEFSR0VU fS9jb25mICYmIFwK --90e6ba6e81ccc1113d04b8a15409--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXPxaMGvsfkVDcURbs9GF_TLMLJSgiFr%2BERYj11T1fdrfA>