From owner-svn-ports-all@FreeBSD.ORG Tue Jul 15 17:05:01 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 7FEA6A57; Tue, 15 Jul 2014 17:05:01 +0000 (UTC) Date: Tue, 15 Jul 2014 17:05:01 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Subject: Re: svn commit: r361646 - in head/net/samba36: . files Message-ID: <20140715170501.GA73101@FreeBSD.org> References: <201407122229.s6CMTN42057554@svn.freebsd.org> <53C322A7.2090705@marino.st> <20140714003112.GA54756@mouf.net> <53C451FA.2020304@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53C451FA.2020304@marino.st> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head , Steve Wills , svn-ports-all , "Timur I. Bakeyev" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 17:05:01 -0000 On Mon, Jul 14, 2014 at 11:56:10PM +0200, John Marino wrote: > On 7/14/2014 22:01, Timur I. Bakeyev wrote: > > You bumped PORTREVISION, although there wasn't any pkg list change - so > > all the users now have to recompile not so tiny samba36 just to fix > > shebang in one rarely used file. > > Kind of like being "almost" pregnant? > If the contents of the package changes *at all* you are supposed to > revbump, not just if the pkg-plist changes. It's not a judgement call > -- if the file is important enough to be in the package, it's important > enough to bump when it changes. Sorry, but I'm on Timur's side here: portrevs bumps are IMHO being abused way too often for little to no benefit. I'm wasting huge deal of CPU cycles for countless rebuilding of perfectly fine packages just because folks tend to bump revs on even teeniest changes. FWIW, having both "not a judgement call" and "important enough" in the same sensence looks like oxymoron to me. ./danfe