From owner-freebsd-gnome@freebsd.org Sat Sep 14 23:25:39 2019 Return-Path: Delivered-To: freebsd-gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0B3DAD237B for ; Sat, 14 Sep 2019 23:25:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46W7sZ6bPcz4bnH for ; Sat, 14 Sep 2019 23:25:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E2431D237A; Sat, 14 Sep 2019 23:25:38 +0000 (UTC) Delivered-To: gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E20BFD2379 for ; Sat, 14 Sep 2019 23:25:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46W7sZ5kwyz4bnG for ; Sat, 14 Sep 2019 23:25:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A82B7272C8 for ; Sat, 14 Sep 2019 23:25:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8ENPcXx057051 for ; Sat, 14 Sep 2019 23:25:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8ENPcBu057050 for gnome@FreeBSD.org; Sat, 14 Sep 2019 23:25:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 240585] audio/pulseaudio: Update to 13.0 : [Attachment 207491] Proposed patch (since 507372 revision) Date: Sat, 14 Sep 2019 23:25:37 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 23:25:39 -0000 lightside has asked freebsd-gnome mailing list for maintainer-approval: Bug 240585: audio/pulseaudio: Update to 13.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240585 Attachment 207491: Proposed patch (since 507372 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207491&action=3Dedit --- Description --- Patch to update audio/pulseaudio port from 12.2 to 13.0 version. Look following links for changes: https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/13.0/ https://gitlab.freedesktop.org/pulseaudio/pulseaudio/compare/v12.2...v13.0 ABI: https://abi-laboratory.pro/tracker/timeline/pulseaudio/ - Remove intltool from USE_GNOME variable [1] - Add src/utils/pa-info to SHEBANG_FILES variable - Add fix for src/pulsecore/atomic.h [2] - Add fix for src/tests/atomic-test.c [3] - Update pkg-plist For reference: 1. Use upstream gettext instead intltool https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/57e3ccaf51f714e= ec8c a29005c3cc4fde456e84e 2. Fixes following error, when using WEBRTC_AEC port's option and Clang compiler: -8<-- In file included from modules/echo-cancel/webrtc.cc:31: In file included from ./pulsecore/modargs.h:29: In file included from ./pulsecore/resampler.h:25: In file included from ./pulsecore/memblock.h:31: ./pulsecore/atomic.h:120:33: error: cannot initialize a parameter of type 'volatile unsigned long' with an lvalue of type 'void *' __atomic_store_n(&a->value, p, __ATOMIC_SEQ_CST); ^ -->8- The GCC compiler doesn't report about this (and probably not affected). This is because of following commit: atomic: fix load and store for armv7 and higher https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/d4ff4adce2808c3= 1898 b4b7d2f60825effb61484 Alternative approach is to define "pulseaudio_cv_atomic_store_n" variable: CONFIGURE_ENV+=3D pulseaudio_cv_atomic_store_n=3D"" The "uintptr_t" type was used because of: https://github.com/freebsd/freebsd/blob/e100f32e6e1cd39a01dea1c5e99ba63fe0a= 2b2e 8/contrib/compiler-rt/lib/builtins/emutls.c#L250 https://github.com/freebsd/freebsd/blob/e100f32e6e1cd39a01dea1c5e99ba63fe0a= 2b2e 8/contrib/compiler-rt/lib/builtins/emutls.c#L320-L327 "Integer type capable of holding a value converted from a void pointer and = then be converted back to that type with a value that compares equal to the orig= inal pointer." http://www.cplusplus.com/reference/cstdint/ 3. Fixes following error (or similar errors): -8<-- tests/atomic-test.c:58:4: error: unknown type name 'cpu_set_t'; did you mean 'cpusetid_t'? cpu_set_t cpuset; ^~~~~~~~~ cpusetid_t -->8- Related to [2], but possible to use "--disable-default-build-tests" configu= re option instead: CONFIGURE_ARGS+=3D --disable-default-build-tests -8<-- % ./configure --help | grep -h1 disable-default-build-tests | tail -2 --disable-default-build-tests Build test programs only during make check -->8-