Date: Thu, 19 Sep 2002 14:53:38 -0700 From: Terry Lambert <tlambert2@mindspring.com> To: Mark Murray <mark@grondar.za> Cc: Bruce Evans <bde@zeta.org.au>, arch@FreeBSD.ORG Subject: Re: More lint work for share/mk/ (review, please) Message-ID: <3D8A4762.9E6253CE@mindspring.com> References: <20020920054221.E2677-100000@gamplex.bde.org> <200209192115.g8JLF57s003495@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Murray wrote:
> > > NOLINT, and this is supposed to be put into individual Makefiles
> > > to kill copious lint output from code out of our control (like
> > > GNU stuff, other contrib/ code and so on).
> >
> > Wouldn't `.undef WANT_LINT' in individual Makefiles be better than
> > another knob?
>
> Maybe. I dunno. There is no precedent for the .undef form, whereas
> we have lots for the WANT_* or NO_* type of knobs. Seems yukky to
> do something that requires another syntax.
I'm a big fan of the general rule:
"Any patch which does not break exisiting functionality,
nor does it preclude future work, is OK with me."
In other words, as long as it doesn't screw anything up, it should
be committed.
You can argue "style changes" under "unreadability precludes future
work", if you want to, but as long as it doesn't screw with anyone's
ability to do future work in the same code, then quit discussing the
the damn thing, and commit it already.
The "NOLINT" vs. "NO_LINT" vs. ".undef WANT_LINT" thing is something
someone else could do, later, if they felt really strongly about the
idea. If no one feels strongly, then fine, let nothing happen. If
someone does, then fine, then let it happen *later*. The person who
writes the code gets to decide what the code does.
I'm surprised that this was even discussed at all on this list, as
it doesn't impact functionality, and permits *more* uses than were
previously permitted.
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D8A4762.9E6253CE>