From owner-freebsd-ports  Mon May 19 23:15:32 1997
Return-Path: <owner-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA15708
          for ports-outgoing; Mon, 19 May 1997 23:15:32 -0700 (PDT)
Received: (from asami@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA15688;
          Mon, 19 May 1997 23:15:29 -0700 (PDT)
Date: Mon, 19 May 1997 23:15:29 -0700 (PDT)
From: Satoshi Asami <asami>
Message-Id: <199705200615.XAA15688@hub.freebsd.org>
To: itojun@itojun.org, asami, freebsd-ports
Subject: Re: ports/3519
Sender: owner-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Synopsis: new port: comms/snooper

State-Changed-From-To: open-closed
State-Changed-By: asami
State-Changed-When: Mon May 19 23:12:13 PDT 1997
State-Changed-Why: 

Thanks, imported.  Diff attached:

===
diff -ru snooper/Makefile snooper.new/Makefile
--- snooper/Makefile	Sat May  3 21:32:03 1997
+++ snooper.new/Makefile	Mon May 19 23:08:06 1997
@@ -6,19 +6,17 @@
 #
 
 DISTNAME=	snooper.970212
-PKGNAME=	snooper
-CATEGORIES=	graphics
+PKGNAME=	snooper-970212
+CATEGORIES=	net
 MASTER_SITES=   ftp://ftp.foretune.co.jp/pub/tools/snooper/
-EXTRACT_SUFX=	.tar.gz
-WRKSRC=		${WRKDIR}/snooper/build
 
+MAINTAINER=	itojun.itojun.org
+
+WRKSRC=		${WRKDIR}/snooper/build
 HAS_CONFIGURE=	yes
 
 post-install:
-	[ -d ${PREFIX}/share ] || ${MKDIR} ${PREFIX}/share
-	[ -d ${PREFIX}/share/doc ] || ${MKDIR} ${PREFIX}/share/doc
-	[ -d ${PREFIX}/share/doc/snooper ] \
-		|| ${MKDIR} ${PREFIX}/share/doc/snooper
+	${MKDIR} ${PREFIX}/share/doc/snooper
 	${INSTALL_DATA} ${WRKSRC}/../README ${PREFIX}/share/doc/snooper
 	${CAT} ${PKGDIR}/MESSAGE
 
===

I assume this was supposed to go into "net", or should it have been
"comms"?  Anyway, I'm pretty sure it doesn't belong to "graphics".

The .tar.gz suffix is the default.  WRKSRC goes in the "other
bsd.port.mk variables" section.

You forgot to add a MAINTAINER line.  I made a wild guess as to who it
should be. :)

No need to create the directories specified by /etc/mtree/BSD.local.dist.
Also, ${MKDIR} includes "-p", so you don't need to check for the
directory's existence.