From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 5 17:00:35 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3AB71065670 for ; Mon, 5 Dec 2011 17:00:35 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D377A8FC14 for ; Mon, 5 Dec 2011 17:00:35 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB5H0Zga011726 for ; Mon, 5 Dec 2011 17:00:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB5H0ZJU011725; Mon, 5 Dec 2011 17:00:35 GMT (envelope-from gnats) Date: Mon, 5 Dec 2011 17:00:35 GMT Message-Id: <201112051700.pB5H0ZJU011725@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Poul-Henning Kamp" Cc: Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Poul-Henning Kamp List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2011 17:00:36 -0000 The following reply was made to PR kern/163076; it has been noted by GNATS. From: "Poul-Henning Kamp" To: Jaakko Heinonen Cc: Petr Salinger , bug-followup@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Mon, 05 Dec 2011 16:38:35 +0000 In message <20111205144947.GA2267@a91-153-116-96.elisa-laajakaista.fi>, Jaakko Heinonen writes: >Yes, r222004 changed sbuf_finish() to not clear s->s_error which causes >the regression. I am not sure if we should blame r222004 or the pseudofs >code. The sbuf code is correct. Sbufs were designed to have "latching error semantics" and any errors should not be cleared by sbuf_finish() for exactly that reason. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.