From owner-svn-src-head@FreeBSD.ORG  Wed Apr  8 17:12:50 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 667451065679
	for <svn-src-head@freebsd.org>; Wed,  8 Apr 2009 17:12:50 +0000 (UTC)
	(envelope-from max@love2party.net)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.177])
	by mx1.freebsd.org (Postfix) with ESMTP id EC1E78FC16
	for <svn-src-head@freebsd.org>; Wed,  8 Apr 2009 17:12:49 +0000 (UTC)
	(envelope-from max@love2party.net)
Received: from vampire.homelinux.org (dslb-088-066-024-239.pools.arcor-ip.net
	[88.66.24.239])
	by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis)
	id 0ML29c-1LrbKS49e3-0001e3; Wed, 08 Apr 2009 19:12:49 +0200
Received: (qmail 45859 invoked from network); 8 Apr 2009 17:12:48 -0000
Received: from fbsd8.laiers.local (192.168.4.200)
	by mx.laiers.local with SMTP; 8 Apr 2009 17:12:48 -0000
From: Max Laier <max@love2party.net>
Organization: FreeBSD
To: Marcel Moolenaar <marcel@freebsd.org>
Date: Wed, 8 Apr 2009 18:12:47 +0100
User-Agent: KMail/1.11.0 (FreeBSD/8.0-CURRENT; KDE/4.2.1; i386; ; )
References: <200904081618.n38GIHG8064477@svn.freebsd.org>
In-Reply-To: <200904081618.n38GIHG8064477@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904081912.48347.max@love2party.net>
X-Provags-ID: V01U2FsdGVkX19Y2D8RGFYuvO8qYBK+ksGQ/8mcaR1vFfle2iL
	6GT2hX3ElgFKfgvSjEXlGM2FY8NIilgtem88AfB/IZowI7fHRD
	oSNjKImQXhdqZzYpnoR9A==
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r190849 - head/sys/geom/part
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2009 17:12:51 -0000

On Wednesday 08 April 2009 18:18:17 Marcel Moolenaar wrote:
> Author: marcel
> Date: Wed Apr  8 16:18:16 2009
> New Revision: 190849
> URL: http://svn.freebsd.org/changeset/base/190849
>
> Log:
>   Don't use hexadecimal in the EBR partition names, because 'a'..'f'
>   are more commonly known as BSD partition names.
>
>   Discussed with: ivoras@
>
> Modified:
>   head/sys/geom/part/g_part_ebr.c
>
> Modified: head/sys/geom/part/g_part_ebr.c
> ===========================================================================
>=== --- head/sys/geom/part/g_part_ebr.c	Wed Apr  8 16:12:28 2009	(r190848)
> +++ head/sys/geom/part/g_part_ebr.c	Wed Apr  8 16:18:16 2009	(r190849) @@
> -344,7 +344,7 @@ g_part_ebr_name(struct g_part_table *tab
>      char *buf, size_t bufsz)
>  {
>
> -	snprintf(buf, bufsz, "+%08x", entry->gpe_index);

Not to bikeshed, but why not use "+%08X" instead?

> +	snprintf(buf, bufsz, "+%08u", entry->gpe_index);
>  	return (buf);
>  }
>
>
>
> !DSPAM:49dcce6b450631134040011!

-- 
/"\  Best regards,                      | mlaier@freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier@EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News