From owner-svn-src-head@freebsd.org Thu Jun 1 20:14:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8A89B7DF6D; Thu, 1 Jun 2017 20:14:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A7D26670E; Thu, 1 Jun 2017 20:14:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id w69so8703462pfk.1; Thu, 01 Jun 2017 13:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=EjWS/XWt9Plf+y1ICKgTp5LSleIIWjYHQby5IEomw1M=; b=gcXvRf9Tqz4ycHlwPw1WCDkV+ju7RW7BPOJSGmbZVY5HmqEcwTYiE4jwb3RtcUn/iB PLnY8kP7yK7pPtqCbtZRsrLQ0VVhl/oEG5p2ZfdTADx306w8hdm4B/s1rPV/EGyeoBUa 4emLHXl6ORhA0gPvzEGxPVUWuUWGlH9EEE4UZI1dJipD57yY8qzPN/avZ0HFAuCm8mk9 sIUIFButWweExzVFeEjd7y9phiw1WCRdZ2AvPGyY3LTB2YCiaZrRhORduubpgAjlf6Qr OwdGmdA0RAIDxwaXsh3ke+ceozYUf/3ZdrcxVBnj94gahM+o9fUBNibWwQ/dyPUBioDv p+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=EjWS/XWt9Plf+y1ICKgTp5LSleIIWjYHQby5IEomw1M=; b=cD0qF82dV2sEafU9aPScL2W19tuAdqkvjYKEPdq7wO+BUvManFO2mJ+3IL5iNQnGiq Midt+LoXiuT83FMxEq7faWCVbIvU5iD/LCmdW9BNoHx92ci/cK0UUdWIFxv0d00sUpVm lIwu2Q+zo4u8YKS0dLXMqWbrQRpTjlfFat6pm0RDvXcAir0Yx/KnvriXBnONyQPGPxC8 OvzsdQrIrRqfVuM7+mj9bqwamqz41dzm/fwdcKsIbciYmILnfhwO3dMJOF1JOSrB4b2e FPgowjkRikHGfOX+GfmEVPXW9jrzGD6v1zPXR0GbPhMjdF2Yh/DC382fL0og+bgFyPZm Pibg== X-Gm-Message-State: AODbwcAcS2kmsqZR0OXk4fZ2LBjV99EJx1Is4nbt2Zm0a74NCnjP/KBU 8ceb1OJKAiOQP8U/w0g= X-Received: by 10.98.60.8 with SMTP id j8mr1940363pfa.216.1496348083856; Thu, 01 Jun 2017 13:14:43 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id k9sm35150204pga.40.2017.06.01.13.14.42 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Jun 2017 13:14:42 -0700 (PDT) Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_BE29C8A1-C058-4F55-BECE-85459E728C42"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170601200605.GA66626@FreeBSD.org> Date: Thu, 1 Jun 2017 13:14:41 -0700 Cc: Marcel Moolenaar , Brooks Davis , svn-src-all@FreeBSD.org, "Simon J. Gerraty" , src-committers , svn-src-head@FreeBSD.org, Ngie Cooper Message-Id: <8EE5D277-E03A-4B90-BDF0-9C0A521567FC@gmail.com> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org> <20170601200605.GA66626@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 20:14:44 -0000 --Apple-Mail=_BE29C8A1-C058-4F55-BECE-85459E728C42 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 1, 2017, at 13:06, Alexey Dokuchaev wrote: >=20 > On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) = wrote: >> ... >> I vote for not checking in the SHAs. If something fails (as someone = else >> mentioned on the lists), it's really hard to debug why it failed. >=20 > Like I've said, it's not "really" hard. Check out previous version = and > generate image with correct hash, there is no strong reason to commit = the > image other than minor usability improvement of not having to check = out > previous version. >=20 > Then again, just my $.02 -- I'm not the one doing actual work here. That=E2=80=99s assuming there aren=E2=80=99t endianness issues, = and less intuitive issues (take the usr.sbin/sa tests for example =E2=80=94= BLEH). With binary files like this, it=E2=80=99s best to do an = abbreviated dump of sorts. Thanks, -Ngie --Apple-Mail=_BE29C8A1-C058-4F55-BECE-85459E728C42 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZMHWxAAoJEPWDqSZpMIYVoQsQAKmil2mH2qrbtQB2/pF4WfIV 6Ep3021wEZYEI6i9ojmkmwhWeLUbBBxRmqgH01QnZBLSjqQl1Drhf8dGJ4IN8zBQ 1qXTmMk14M91r9qj3Ux339W/HsLCk1/LfbryGzTNWk8J8bfesFFwYBwtNKA7MZnd UTNwEIsbrkOEKbStERPVG9cXWDFS5Z0sz4Oq5mN4DooZ2XQtJ2TqvZ8p08R+gf/D 3NfAs8IgMD7ZWr41/jmd2Dmbw0kHJMSt+HybUOrQe2N1IrwEOugaEnmrJXaKtMBW 5HR9m638sn8J13prCPf/O+WAcOmdRmz+VwGpZnLXU1Bx9EUUdBQtP0Ipg8GJe/Px O+pR3kQE0VwVWlNPRWoUQXP6l7rUX2uAIGsL0dIGN4ZzcMdPo+cZclxBhA4H3LUc Hqo0m8CKQHN2RXHlH+68VbmDIYxo0weyZV5/S36Pqhlbb+AG0lRmKllOd/ndOcEP g2ZDAuH2oyDXaJSDB1R0HoFlnZtCP1Wy1SaaZgDyZjmk9pHwjGd2QzIjMfWkp0Da P5SleimxKpjV7TeKLc5Py3DnujraHqSZxJnzQCzBK4xgoCeDDLNyvQkRW/zmod9L PAhjCGU642VKFl3p0dr3NgnFX/QPUpd4aJP8Ft8d9Ndb3XDHBl41aah2QGDfyK/X wSuwHvtHVSQULtzzulO0 =B45j -----END PGP SIGNATURE----- --Apple-Mail=_BE29C8A1-C058-4F55-BECE-85459E728C42--