From owner-cvs-all Tue Oct 29 10:25:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E67637B401; Tue, 29 Oct 2002 10:25:40 -0800 (PST) Received: from mail-green.research.att.com (H-135-207-30-103.research.att.com [135.207.30.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id B836243E75; Tue, 29 Oct 2002 10:25:39 -0800 (PST) (envelope-from fenner@research.att.com) Received: from alliance.research.att.com (alliance.research.att.com [135.207.26.26]) by mail-green.research.att.com (Postfix) with ESMTP id 229EC1E03B; Tue, 29 Oct 2002 13:25:39 -0500 (EST) Received: from windsor.research.att.com (windsor.research.att.com [135.207.26.46]) by alliance.research.att.com (8.8.7/8.8.7) with ESMTP id NAA13708; Tue, 29 Oct 2002 13:25:37 -0500 (EST) From: Bill Fenner Received: (from fenner@localhost) by windsor.research.att.com (8.8.8+Sun/8.8.5) id KAA07175; Tue, 29 Oct 2002 10:25:37 -0800 (PST) Message-Id: <200210291825.KAA07175@windsor.research.att.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: obrien@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch common.c Cc: des@ofug.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200210271720.g9RHKnUS015686@repoman.freebsd.org> <20021029030118.GA36927@dragon.nuxi.com> <20021029115934.GA8665@dragon.nuxi.com> Date: Tue, 29 Oct 2002 10:25:36 -0800 Versions: dmail (solaris) 2.5a/makemail 2.9d Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >(gdb) where >#0 bcopy () at {standard input}:57 >#1 0x08050080 in ?? () >#2 0x28213ed6 in _sread (fp=0x28238640, > buf=0x804f400 >"ÝÁ;ù\016±\234çÅ\023ßâ\036à¨ø]\023\006\200¢2ç\030)\r\021á\224.\2155Ó+û¦.´èê\ >206^LÈg0òsI\026\026L\204n|h.N\227a$\n\226~Ö\203ù´#öµÿÌÛ¼£Æî >ý|\237©à{}N>ï\206\225êâ|\217â¥\035è\003ÂAB öµ\221G`rK\206\003\204+v'a\215ÐRe >±Ëëð\017**y\220\003®\217.\026\231³f\222Zâà*#©àÌ´\023$Dî²Ñ)1È*&8edñ\222\204fÀ >?9¯!C", > n=134542336) at /usr/src/lib/libc/stdio/stdio.c:107 >#3 0x28201e49 in __srefill (fp=0x804cb00) > at /usr/src/lib/libc/stdio/refill.c:138 >#4 0x281fc627 in fread (buf=0x804e000, size=1, count=4096, fp=0x28238640) > at /usr/src/lib/libc/stdio/fread.c:80 #1 is _fetch_read(), which was broken in rev 1.34 (and then further in 1.37) to not return 0 on EOF. stdio depends pretty heavily on a zero return at EOF, so it'd be nice for _fetch_read() to cooperate. Bill To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message