From nobody Fri Feb 28 15:53:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z4CRv0MDyz5m7nH; Fri, 28 Feb 2025 15:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z4CRt6Wy3z3vHZ; Fri, 28 Feb 2025 15:53:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bICeD2S3A81nSG1D/ngIcKicp9xvQcxwBW0BUk43ijU=; b=d5FpGRaQNkDPx/gk1ZIPO1Ysyts2GBDnXZJ5cutZ9igoY/xO4fHZM3u/mm2H+LlvDwjDxk ir5JSOx6ljMHHdGCcLWw/PEmvuK/m0o1KmA8RDZD/EttNeGMNfjonMC+G7de41Pk3quBHy i6kqqJF37Ykn+NzWxWyZoXE0Sm/Z/r5Yx+4gplaUXIB4f41yXdy6jsueONZg2r142PeUPf a5jLm3OpId7pe8feOhmxARPskWXDcPkV4+zBeTV5EFvczP6qttFf8vsz8uPdJ/8KtqAMte 1q7a9JELYRz6qqTexdqLxzPtkJBPvR4GAy7S36OFYe/+eu7lOTJrEkEOgEu59g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740758026; a=rsa-sha256; cv=none; b=iwj50cILmy4Rccc3ufgJi3FgTDpmNm116Pq0IN4KpCGEaAT0IRIydHg79PIs1lvPvt4DXC ixYSBz9zgoe9wq3uRxRFcUnRUQ8hRBZn+OQBbgkpEcb1vDKZzUv82tc3P53lBPoX6CubAQ 5cQd62fbRIBw6pHLtEX0YNQYGdw6mEvTzpDDCKz2pgQzwywxxEbG35WbFdBgx03LA7JZhk IIBL04Iwa+l/aZkBW9OdE9ZTLgZ1+NZojsHWRJTPXWVikRWV5WhaKmwFa3HQJ6ekWAcDF/ FJxFFsQnolXZbOFOyRMcwcyL0rrt4pzTgr8zjnAIK1Nmk9mcyVnhRNbyJieTmQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bICeD2S3A81nSG1D/ngIcKicp9xvQcxwBW0BUk43ijU=; b=iuJ8i8LSoU8okqe2/V2nLzkuKc3aoxX7PbTgPn8AVtlHja6F2OMzrnAMYgORQMjMHDEp13 e4B5R2n6GzNxFPVaZ906uJa1bzRbslKP7eBPsU+ALO1p5Yuotb9lfzyyNLMZCYhHXEYHd4 yIRKYTj6CqiBv8j6y+4y2IcWiN3yBkmS/rrTNdHASWHPw8lX82lC7/KhtD/tRjjp4gXPKQ 78ubRUNlWnzjE/o14SYBmQ03EjPVMmPap4eKRinyQAUX/BxhzChPGTHxx3uTWA51HQNXsa k0GYUA9XFtPB6Nub796AaPcSYUcdg6wLo+yS2MY7RFgaFjI64wItmi/n4AUnjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z4CRt5xPnzc9t; Fri, 28 Feb 2025 15:53:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51SFrkiF099047; Fri, 28 Feb 2025 15:53:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51SFrkfQ099044; Fri, 28 Feb 2025 15:53:46 GMT (envelope-from git) Date: Fri, 28 Feb 2025 15:53:46 GMT Message-Id: <202502281553.51SFrkfQ099044@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 628715fdcc9f - main - ntp: NULL pointer deref when create_interface() fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc Auto-Submitted: auto-generated The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc commit 628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc Author: Cy Schubert AuthorDate: 2025-02-28 15:46:23 +0000 Commit: Cy Schubert CommitDate: 2025-02-28 15:53:22 +0000 ntp: NULL pointer deref when create_interface() fails Fix NULL pointer dereference when create_interface() fails in update_interfaces(). The upstream bug report says a typo was introduced by https://bk.ntp.org/ntp-dev/ntpd/ntp_io.c?PAGE=diffs&REV=66175036PETA6g__fON8oNrjL54Ttw. ep should have been ep2. Fix obtained from upstream bug report. PR: 285065 Upstream bug: https://bugs.ntp.org/show_bug.cgi?id=3939 MFC after: 1 minute --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 6a796101b0e8..9c4f6c1553e3 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1919,7 +1919,7 @@ update_interfaces( } else { DPRINT_INTERFACE(3, - (ep, "updating ", " new - FAILED")); + (ep2, "updating ", " new - FAILED")); msyslog(LOG_ERR, "cannot bind address %s",