From owner-svn-src-head@FreeBSD.ORG Sun Aug 31 14:04:31 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E880DFED; Sun, 31 Aug 2014 14:04:30 +0000 (UTC) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A4DB1AEC; Sun, 31 Aug 2014 14:04:30 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 138A325D388C; Sun, 31 Aug 2014 14:04:27 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 2871BC770B1; Sun, 31 Aug 2014 14:04:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id vQ6LRbUSBBIO; Sun, 31 Aug 2014 14:04:25 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:f973:5b8d:9a90:cf0f] (unknown [IPv6:fde9:577b:c1a9:4410:f973:5b8d:9a90:cf0f]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id C1068C770B0; Sun, 31 Aug 2014 14:04:23 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r270877 - head/sys/net From: "Bjoern A. Zeeb" In-Reply-To: <1EC00F70-7E6E-448F-AE85-BE87A3C753A1@FreeBSD.org> Date: Sun, 31 Aug 2014 14:03:59 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201408311330.s7VDUtLH040605@svn.freebsd.org> <1EC00F70-7E6E-448F-AE85-BE87A3C753A1@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2014 14:04:31 -0000 On 31 Aug 2014, at 13:58 , Bjoern A. Zeeb wrote: >=20 > On 31 Aug 2014, at 13:30 , Gleb Smirnoff wrote: >=20 >> Author: glebius >> Date: Sun Aug 31 13:30:54 2014 >> New Revision: 270877 >> URL: http://svnweb.freebsd.org/changeset/base/270877 >>=20 >> Log: >> Toss fields so that no padding field is required to achieve = alignment. >>=20 >> Modified: >> head/sys/net/if_var.h >>=20 >> Modified: head/sys/net/if_var.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/net/if_var.h Sun Aug 31 12:48:13 2014 = (r270876) >> +++ head/sys/net/if_var.h Sun Aug 31 13:30:54 2014 = (r270877) >> @@ -146,11 +146,11 @@ struct ifnet { >>=20 >> /* Variable fields that are touched by the stack and drivers. */ >> int if_flags; /* up/down, broadcast, etc. */ >> + int if_drv_flags; /* driver-managed status flags = */ >> int if_capabilities; /* interface features & = capabilities */ >> int if_capenable; /* enabled features & = capabilities */ >> void *if_linkmib; /* link-type-specific MIB data = */ >> size_t if_linkmiblen; /* length of above data */ >> - int if_drv_flags; /* driver-managed status flags = */ >> u_int if_refcount; /* reference count */ >>=20 >> /* These fields are shared with struct if_data. */ >> @@ -158,7 +158,6 @@ struct ifnet { >> uint8_t if_addrlen; /* media address length */ >> uint8_t if_hdrlen; /* media header length */ >> uint8_t if_link_state; /* current link state */ >> - uint32_t if_spare32; >=20 > Doesn=92t this leave a gap on 64bit alignment now again? Disregard. It=92s fine. >=20 >> uint32_t if_mtu; /* maximum transmission unit */ >> uint32_t if_metric; /* routing metric (external = only) */ >> uint64_t if_baudrate; /* linespeed */ >>=20 >=20 > =97=20 > Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, = 1983 >=20 >=20 =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983