From owner-cvs-all@FreeBSD.ORG  Wed Apr 23 13:19:46 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6C58106567C;
	Wed, 23 Apr 2008 13:19:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 9519B8FC1C;
	Wed, 23 Apr 2008 13:19:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (unknown [208.65.91.234])
	by elvis.mu.org (Postfix) with ESMTP id 434F01A4D7E;
	Wed, 23 Apr 2008 06:19:46 -0700 (PDT)
From: John Baldwin <jhb@freebsd.org>
To: Peter Wemm <peter@freebsd.org>
Date: Wed, 23 Apr 2008 08:58:30 -0400
User-Agent: KMail/1.9.7
References: <200804190725.m3J7Pvie056329@repoman.freebsd.org>
In-Reply-To: <200804190725.m3J7Pvie056329@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200804230858.31200.jhb@freebsd.org>
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Apr 2008 13:19:46 -0000

On Saturday 19 April 2008 03:25:57 am Peter Wemm wrote:
> peter       2008-04-19 07:25:57 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/amd64/amd64      machdep.c
>   Log:
>   Put in a real isa_irq_pending() stub in order to remove two lines of
> dmesg noise from sio per unit.  sio likes to probe if interrupts are
> configured correctly by looking at the pending bits of the atpic in order
> to put a non-fatal warning on the console.  I think I'd rather read the
> pending bits from the apics, but I'm not sure its worth the hassle.

Actually, the x86 interrupt sources have a pending method so this can be 
replaced.  Could probably easily write something like this:

int
intr_pending(u_int irq)
{
	struct intsrc *isrc;

	isc = intr_lookup_source(irq);
	if (isrc == NULL)
		panic("bizarre");
	return (isrc->is_pic->pic_pending(isrc));
}

For intr_machdep.c and use this in sio:

#if defined(__i386__) || defined(__amd64__)
	foo = intr_pending(rman_get_start(irq_resource));
#else
	foo = isa_irq_pending() & (1 << rman_get_start(irq_resource));
#endif

or some such.  I'd really prefer to kill isa_irq_pending().

-- 
John Baldwin