From owner-cvs-src@FreeBSD.ORG  Sat Mar  8 18:55:08 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2BD8B1065670;
	Sat,  8 Mar 2008 18:55:08 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id DB67F8FC14;
	Sat,  8 Mar 2008 18:55:07 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 948CB41C7A3;
	Sat,  8 Mar 2008 19:55:05 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id n5KtJ8qteyzF; Sat,  8 Mar 2008 19:55:04 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id E763141C7A7; Sat,  8 Mar 2008 19:55:04 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 60B8B44487F;
	Sat,  8 Mar 2008 18:53:37 +0000 (UTC)
Date: Sat, 8 Mar 2008 18:53:37 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200803081834.m28IYHB6035877@repoman.freebsd.org>
Message-ID: <20080308185230.Q50685@maildrop.int.zabbadoz.net>
References: <200803081834.m28IYHB6035877@repoman.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Re: cvs commit: src/sys/netipsec key.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Mar 2008 18:55:08 -0000

On Sat, 8 Mar 2008, Bjoern A. Zeeb wrote:

> bz          2008-03-08 18:34:17 UTC
>
>  FreeBSD src repository
>
>  Modified files:        (Branch: RELENG_6)
>    sys/netipsec         key.c
>  Log:
>  MFC rev. 1.25
>
>    Add a missing return so that we drop out in case of an error and
>    do not continue with a NULL pointer. [1]
>
>    While here change the return of the error handling code path above.
>    I cannot see why we should always return 0 there. Neither does KAME
>    nor do we in here for the similar check in all the other functions.
>
>    Found with:     Coverity Prevent(tm) [1]
>    CID:            2521
>
>  Revision  Changes    Path
>  1.20.2.3  +2 -3      src/sys/netipsec/key.c


The problem (which was a missing MFC) was
Reported by:	Matthew Grooms mgrooms shrew.net
PR:		121140

-- 
Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
Software is harder than hardware  so better get it right the first time.