From owner-freebsd-ports Sun Sep 23 11:30:38 2001 Delivered-To: freebsd-ports@freebsd.org Received: from franklin.physics.purdue.edu (franklin.physics.purdue.edu [128.210.146.222]) by hub.freebsd.org (Postfix) with ESMTP id 98F5E37B411; Sun, 23 Sep 2001 11:30:33 -0700 (PDT) Received: from physics.purdue.edu (curie.physics.purdue.edu [128.210.68.223]) by franklin.physics.purdue.edu (Postfix) with ESMTP id 2E50720F09; Sun, 23 Sep 2001 13:30:40 -0500 (EST) Received: by physics.purdue.edu (Postfix, from userid 12409) id B154F7E; Sun, 23 Sep 2001 13:30:30 -0500 (EST) Date: Sun, 23 Sep 2001 13:30:30 -0500 From: Will Andrews To: sobomax@FreeBSD.org Cc: lioux@uol.com.br, FreeBSD-ports@FreeBSD.ORG, portmgr@FreeBSD.ORG, pat@databits.net, fenner@FreeBSD.ORG, kris@FreeBSD.ORG, green@FreeBSD.ORG, knu@FreeBSD.ORG, julian@FreeBSD.ORG, petef@FreeBSD.ORG, cwasser@v-wave.com, sjh-cl@horan.net.au, john_m_cooper@yahoo.com, matt@ipperformance.com Subject: Re: review plz MASTER_SITES_n (ala OpenBSD) patch for bsd.port.mk Message-ID: <20010923133030.K69123@curie.physics.purdue.edu> Reply-To: Will Andrews Mail-Followup-To: sobomax@FreeBSD.org, lioux@uol.com.br, FreeBSD-ports@FreeBSD.ORG, portmgr@FreeBSD.ORG, pat@databits.net, fenner@FreeBSD.ORG, kris@FreeBSD.ORG, green@FreeBSD.ORG, knu@FreeBSD.ORG, julian@FreeBSD.ORG, petef@FreeBSD.ORG, cwasser@v-wave.com, sjh-cl@horan.net.au, john_m_cooper@yahoo.com, matt@ipperformance.com References: <20010923055224.A93855@exxodus.fedaykin.here> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.17i In-Reply-To: ; from sobomax@mail.ru on Sun, Sep 23, 2001 at 03:25:05PM +0400 X-Operating-System: FreeBSD 4.3-STABLE i386 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Sep 23, 2001 at 03:25:05PM +0400, Maxim Sobolev (sobomax@mail.ru) wrote: > Thank you for a great work, it is really step in the right direction. Yeah! It is awesome! I've reviewed the diff and I believe it is very well done. I'd like to test a final version of this patch plus patches to the various ports in my bento tree (mainly KDE and its dependneices) and see how it goes. Any objections to this method of testing? If someone else wants to add other ports for the sole purpose of testing this patch, I'll do that too. > I have not reviewed the implementation yet, but the writeup is really > interesting and well thought out. At the same time, I am not very happy > with the resulting Makefile bloat, and have a quick idea, which may or > may not be a better way out: I agree. > Why not in addition to postfixes in DISTFILES introduce the same > postfixes in MASTER_SITES and MASTER_SITE_SUBDIR? This would allow > to avoid introducing MASTER_SITES_foo, turning your example below > into: I like this: > MASTER_SITES= http://master7/:n \ > http://master1/:t http://master2/:t http://master3/%SUBDIR%/:t \ > http://master4/:y http://master5/:y http://master6/%SUBDIR%/:y \ > http://master8/:p > DISTFILES= file1:t file2:y file3:n file4:o:p > MASTER_SITE_SUBDIR= subdir:t subdir_test:y But, there's a small problem here. I believe ':' is a valid URI character, and I believe _some_ places have actually used this character. But I am not sure. Would it be possible to use a different character for the delimiter? -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message